Comments (1)
Hey there, dev of fpm here. In regards to fab52cc, that's not technically the correct fix. You added the mod as a compile dependency and then don't actually use it(FabricLoader.getInstance().isModLoaded("firstperson");
works without having it added). The firstperson mod can be toggled, and just because the player is in first person and gets rendered doesn't mean it's the mod doing it. Other mods like paperdoll and shaders do that too, so with the current fix the backpack would just vanish for them while swimming.
Three potential solutions:
- Just check for the torso invisible flag being set. While swimming just during the first person render call(so not shader/paperdoll etc) the torso is set to not render so it can't clip into the camera. This might be a decent and easy general workaround.
- I can look into adding the workarounds I added to the head for better mod support to the torso too. This would not only make the torso invisible, but also move it a few hundred blocks behind the camera. So during the
ModelPart modelPart = playerEntityModel.body;
modelPart.rotate(matrices);
Code the backpack also gets moved far away from where it would be visible.
- Since you did add the mod as a compile dependency, you could just check
https://github.com/tr7zw/FirstPersonModel/blob/1.20.2/Shared/src/main/java/dev/tr7zw/firstperson/api/FirstPersonAPI.java#L42
the API + isSwimming() and that's it. Keep in mind that you need to isolate that code correctly so your mod doesn't crash when trying to check that flag while fpm isn't installed.
from inmisaddon.
Related Issues (14)
- Client crash HOT 2
- Crash on Startup HOT 2
- 1.19.2 - Crash on Startup - Incompatibility with Ferritecore HOT 2
- Crash on startup HOT 1
- InmisAddon thinks fabric-api is missing HOT 8
- Crashes without Trinkets also installed HOT 1
- Modrinth upload HOT 1
- 1.17 HOT 1
- If Baby backpack is disabled, its model is still used on the next bag
- backpack appears invisible to other players when joining a multiplayer server.
- Project Distribution HOT 2
- [Bug] Wrong backpack is used in tabs
- [Feature Request]: Placeable 3D Backpacks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inmisaddon.