Comments (6)
This is a lot change across the code-base. Lot of pending patches may get into merge conflicts:
This is what I got.
[atumball@dhcp35-224 glusterfs]$ git grep gf_boolean_t | wc -l
2064
[atumball@dhcp35-224 glusterfs]$ git grep gf_true | wc -l
1492
[atumball@dhcp35-224 glusterfs]$ git grep gf_false | wc -l
1731
from glusterfs.
Yes, it's a lot of change. We can address the wasted-space problem pretty simply like this:
#include <stdbool.h>
typedef boolean gf_boolean_t;
#define _gf_true true
#define _gf_false false
However, that still doesn't address the issues of incomprehensibility and unfriendliness to newcomers. Only a true rename (which should be easy to automate) will truly put this offputting Gluster-ism behind us.
from glusterfs.
A patch https://review.gluster.org/18601 has been posted that references this issue.
Commit message: core: make gf_boolean_t a C99 bool instead of an enum
from glusterfs.
A patch https://review.gluster.org/18601 has been posted that references this issue.
Commit message: core: make gf_boolean_t a C99 bool instead of an enum
from glusterfs.
A patch https://review.gluster.org/18601 has been posted that references this issue.
Commit message: core: make gf_boolean_t a C99 bool instead of an enum
from glusterfs.
Considering this is technical debt, and no release notes required for this. Good to close now after the patch got merged.
from glusterfs.
Related Issues (20)
- Georeplication : unpredictable mapping between primary nodes and secondary nodes HOT 4
- Is it possible to use a different user on each node for a georeplication session? HOT 2
- [RFE] Manual option to select Active Geo-replication worker
- ubuntu 22.04 10.1 gluster vs 11.1 performance HOT 2
- Client issue: client-rpc-fops_v2.c:2618:client4_0_lookup_cbk - remote operation failed - error=No data available + periodic loss of mount on native client
- Unable to mount local volume at boot (Debian bullseye) HOT 3
- Error in loopback detection fails hostnamens starting with 0. HOT 1
- bug report HOT 1
- fallocate with flag FALLOC_FL_ZERO_RANGE failed HOT 7
- Strange issue with permission denied and bizarre mtime HOT 5
- sq: rename may cause statistical issue HOT 1
- sq: df show wrong usage after file deleted
- Gluster Linked File Issues during Healing HOT 1
- qemu-img create via libfapi is slow HOT 8
- [BUG] Geo-rep transfers large files multiple times while using Tar+ssh HOT 3
- Segmentation fault gluster volume status all clients HOT 9
- Errors creating files via qemu-img / libgfapi
- The rights to folders and files from the glusterfs client are flying off HOT 2
- glusterfs: symbol lookup error: /lib/x86_64-linux-gnu/libgfrpc.so.0: undefined symbol: gf_async_ctrl HOT 1
- Transport endpoint is not connected HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glusterfs.