Giter Site home page Giter Site logo

Comments (6)

amarts avatar amarts commented on April 27, 2024

This is a lot change across the code-base. Lot of pending patches may get into merge conflicts:

This is what I got.

[atumball@dhcp35-224 glusterfs]$ git grep gf_boolean_t | wc -l
2064
[atumball@dhcp35-224 glusterfs]$ git grep gf_true | wc -l
1492
[atumball@dhcp35-224 glusterfs]$ git grep gf_false | wc -l
1731

from glusterfs.

jdarcy avatar jdarcy commented on April 27, 2024

Yes, it's a lot of change. We can address the wasted-space problem pretty simply like this:

#include <stdbool.h>
typedef boolean gf_boolean_t;
#define _gf_true true
#define _gf_false false

However, that still doesn't address the issues of incomprehensibility and unfriendliness to newcomers. Only a true rename (which should be easy to automate) will truly put this offputting Gluster-ism behind us.

from glusterfs.

gluster-ant avatar gluster-ant commented on April 27, 2024

A patch https://review.gluster.org/18601 has been posted that references this issue.
Commit message: core: make gf_boolean_t a C99 bool instead of an enum

from glusterfs.

gluster-ant avatar gluster-ant commented on April 27, 2024

A patch https://review.gluster.org/18601 has been posted that references this issue.
Commit message: core: make gf_boolean_t a C99 bool instead of an enum

from glusterfs.

gluster-ant avatar gluster-ant commented on April 27, 2024

A patch https://review.gluster.org/18601 has been posted that references this issue.
Commit message: core: make gf_boolean_t a C99 bool instead of an enum

from glusterfs.

amarts avatar amarts commented on April 27, 2024

Considering this is technical debt, and no release notes required for this. Good to close now after the patch got merged.

from glusterfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.