Comments (6)
But if the user has more balance that what specified in the order amount, we should not be using the full address balance but only use the amount specified in the order.
from gp-v2-contracts.
We also have an issue tracking it so we don't forget #68
Let's reopen it then đ
from gp-v2-contracts.
It is my understanding that for fill or kill orders, if the order amount is greater than either the allowance or balance, then it is not accepted.
from gp-v2-contracts.
The issue is the other way around: if the order-specified amount is smaller than that, then the min between the balance and the allowance is used as the amount.
from gp-v2-contracts.
I think if a user doesn't have enough balance for the signed amount we need to kill the order since we cannot completely fill it.
from gp-v2-contracts.
Given the current design, this case is more about ensuring partially fillable orders executed amounts are less than the remaining amount in the order.
from gp-v2-contracts.
Related Issues (20)
- Update to latest Balancer contracts.
- Add custom limit amount for swap fast path
- Add `OrderBalance.ERC20` as a valid value for sell token balance `0b01` flag value
- Stricter order balance typing in TypeScript library
- Add useful flags to withdraw task
- Update Settlement Decoding to latest contracts.
- Investigate `hardhat-deploy` issues when changing deployment salt.
- [audit] GPv2Settlement.sol
- `dump` task will attempt transfer even if balance is 0.
- Tokens that are not traded do not get included in withdraw list
- Tokens that were traded and then became "invalid" can no longer be swapped.
- Allow specifying a maximum withdraw/dump batch size
- `dump` script display order information and wait
- [đĽA1] Gnosis Protocol Token Contracts Audit HOT 3
- Long approval times invalidate fees. HOT 1
- [Cowswap] API Price Strategy check endpoint HOT 2
- `dump` script can fail to place orders when approvals take too long.
- Implement faster way of getting largest token balances for WithdrawService
- Fix block native price estimation access HOT 1
- A HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
đ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. đđđ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google â¤ď¸ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gp-v2-contracts.