Giter Site home page Giter Site logo

Comments (6)

fedgiac avatar fedgiac commented on June 30, 2024 1

But if the user has more balance that what specified in the order amount, we should not be using the full address balance but only use the amount specified in the order.

from gp-v2-contracts.

fleupold avatar fleupold commented on June 30, 2024 1

We also have an issue tracking it so we don't forget #68

Let's reopen it then 😄

from gp-v2-contracts.

nlordell avatar nlordell commented on June 30, 2024

It is my understanding that for fill or kill orders, if the order amount is greater than either the allowance or balance, then it is not accepted.

from gp-v2-contracts.

fedgiac avatar fedgiac commented on June 30, 2024

The issue is the other way around: if the order-specified amount is smaller than that, then the min between the balance and the allowance is used as the amount.

from gp-v2-contracts.

fleupold avatar fleupold commented on June 30, 2024

I think if a user doesn't have enough balance for the signed amount we need to kill the order since we cannot completely fill it.

from gp-v2-contracts.

nlordell avatar nlordell commented on June 30, 2024

Given the current design, this case is more about ensuring partially fillable orders executed amounts are less than the remaining amount in the order.

from gp-v2-contracts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.