Error: VM Exception while processing transaction: revert

[gnosis]

Error: VM Exception while processing transaction: revert

[denisgranha]

@mesqueeb can you try MultiSigWalletWithDailyLimit.contract.new instead of MultiSigWalletWithDailyLimit.new if my memory doesn't fail

[mesqueeb]

Dear @denisgranha Thank you very very much.
This indeed solved my problem!

I wonder why, because your tests are written without .contract in between!
Do you know the reason?

From your MultisigWallet test:

const deployMultisig = (owners, confirmations, limit) => {
    return MultiSigWalletWithDailyLimit.new(owners, confirmations, limit)
}

[mesqueeb]

I'm running this custom testrpc node:

#!/bin/bash

ganache-cli -p 9545 -l 4700000 --account="0x8445abbbcf2911a2db42fced93efe0d7b3172295c99b01a9e02197ff52f30a53,20000000000000000000000000" --account="0x580324cb2abc8029d6eb5a14650a8bd77f48be478c7ece07afd777755070128c,20000000000000000000000000" --account="0x3e478e4fed09cdc68388286b94aeb1404df47b1f1df0de715e582d6aebc6e1c9,20000000000000000000000000" --account="0xa0d45d6a3911221c4e1b7edcd256741c6bcb9a247fda017a8946ff5f5c38021a,200000000000000000000" --account="0x1386ff12f7d49e6e4e835952493d034570e134bfb0fc6f9d17b49dbdf88d03b3,200000000000000000000" --account="0xf84d5b9d64e427d43645e3c12906d322410a87b277374a0335a4ca0da9316d23,200000000000000000000" 

[mesqueeb]

@denisgranha Just curious for my own understanding & learning point of view:

What's the difference between MultiSigWalletWithDailyLimit.contract.new instead of MultiSigWalletWithDailyLimit.new. Is this a web3 related thing?
Do you have any recommendation for me to read up on related to this particular behaviour?

[mesqueeb]

@denisgranha
A new related bug seems to have appeared.
When trying my setup again today I get: TypeError: Cannot read property 'new' of undefined

So MultiSigWalletWithDailyLimit.contract.new() doesn't exist anymore...

The only difference is that because of Node I had to write these lines in my deploy script inside a try block:

try {
    wallet = await MultiSigWalletWithDailyLimit.contract.new([multisigWalletAddress1, multisigWalletAddress2], 2, multisigWalletDailyLimit)
    console.log(`MultisigWallet: ${wallet.address}`)

Other libraries like truffle shouldn't be changed as I use fixed versions:

npm install -g [email protected]
npm install -g [email protected]
npm install [email protected]

[denisgranha]

what was the issue @mesqueeb ? :)

[mesqueeb]

Solved by deleting the contract keyword again.
This time I didn't get the bug I had initially when calling without the contract keyword.

I'm still not sure what the contract keyword does... I'd love some hint on what contract does! : D

[denisgranha]

ah ok ^^
So, maybe you should use https://github.com/trufflesuite/truffle-contract in order to load the source code

[denisgranha]

http://truffleframework.com/docs/getting_started/scripts it's more oriented for set ups, test settings... I would say