route53: aws-sdk-go-v2 no longer allows empty region

[jspdown]

route53: aws-sdk-go-v2 no longer allows empty region

[jspdown]

After some digging with the help of Traefik community in traefik/traefik#10195, we've located a regression since the upgrade from aws-sdk-go v1.39.0 to aws-sdk-go-v2 v1.19.0 introduce in that commit fc47c35

aws-sdk-go didn't force the user to specify an AWS region on some service. You can find the list of services here: https://github.com/aws/aws-sdk-go/blob/7087ed2d41a8462e40c00a473fa884d79124b660/aws/endpoints/v3model.go#L183-L200

But the new version aws-sdk-go-v2 is much more strict and doesn't allow it.
The fact that we didn't see it coming in the unit tests is because it's a check done in the endpoint Resolver that we mock: https://github.com/aws/aws-sdk-go-v2/blob/57a201c7bb214737f78cf871fbeafaa929bf1d8d/service/route53/internal/endpoints/endpoints.go#L66-L77

[ldez]

Hello,

You said:

I would expect to still be able to not provide an AWS region.

and

But the new version aws-sdk-go-v2 is much more strict and doesn't allow it.

We will not revert the migration to the aws-sdk-go-v2, so what is your suggestion?

[jspdown]

Just reporting the issue, from the outside it's a regression.

Now I understand that there's no much we can do. If we provided a default region directly in Lego like it's done in lightsail, it would create even more breaking change for those using AWS_SDK_LOAD_CONFIG.

So yes, I agree with you. Can't be fixed.

[ldez]

So we agree on the conclusion: it can't be fixed, the region is now a requirement but it depends on the type of credentials used to authenticate.