Allow overwrite function methodNotAllowedHandler

[ivoszz]

Allow overwrite function methodNotAllowedHandler

[pkieltyka]

hey @ivoszz I see, potentially I can put a MethodNotAllowedHandler http.Handler on the chi.Mux and let you set it there. That will work but I need to check the interaction with subrouters.

[pkieltyka]

@ivoszz I was just checking into this, and it seems the current methodNotAllowedHandler just returns 405 with an empty body, so it should be valid to the response of your json handler

[ivoszz]

hey @pkieltyka you are right. The body is empty but still marked as text/html and this doesn't solve the problem of JSON api. text/html is hard coded and cannot be changed even when there are Accept: application/json or application/vnd.api+json in request header. The header Allow is also not generated (and cannot be) which is against the spec:
"The origin server MUST generate an Allow header field in a 405 response containing a list of the target resource's currently supported methods."
The possibility of redefining methodNotAllowedHandler will be sufficient.

[pkieltyka]

got it, good points

[ivoszz]

I would like to thank you for your effort.

[pkieltyka]

:) no prob