Type chi.Middleware

[go-chi]

Type chi.Middleware

[GeertJohan]

I'd be happy to provide a PR if necessary.

[utrack]

👍

[pkieltyka]

Hey @GeertJohan - a shorthand would be nice, but it would only save a bit of typing.. as so..

func NewSomethingCtx(stuff *Stuff)  chi.Middleware  {
    return chi.Middleware(func(next chi.Handler) chi.Handler {
        // stuff can be used here to set something up (should be done once, as mentioned in #10).
        return chi.HandlerFunc(func(ctx context.Context, w http.ResponseWriter, r *http.Request) {
            // stuff can also be used here, on each request.
            // actual middleware.
        })
    })
}

Im not convinced thats much better. Do you see another way? if so, it would be great to see a quick PR for the discussion.

[GeertJohan]

I liked it for documentation and readability. However, when trying to implement a quick example I found that it gets messy real quick. Existing func(next chi.Handler) chi.Handler must still need be supported and since router.Use(..) accepts interface{} there can't be any type conversion going on during the call, which means that internally both types must be handled. It's probably not worth the effort without unless doing a breaking change.

[GeertJohan]

Didn't mean to close, although this probably can be closed..?

[pkieltyka]

I'd like to keep the middleware signature as close to the standard http.Handler middlewares. I'm going to close this ticket, but if you find an elegant approach please submit a PR. Thanks for the feedback!