Subrouter hides parent routes

[go-chi]

Subrouter hides parent routes

[pkieltyka]

What should it do?

Cuz the r.Mount() route is the same as the get request, and overwrites it. You should define the / route in the subrouter if it's using the same name, since that is its domain

On Jan 25, 2016, at 9:11 PM, Vojtech Vitek [email protected] wrote:

package main

import (
"log"
"net/http"

"github.com/pressly/chi"

)

func main() {
r := chi.NewRouter()

// Parent route -- /foo
r.Get("/foo", func(w http.ResponseWriter, r *http.Request) {
    log.Println("/foo")
})

// Subrouter -- /foo/bar
r.Mount("/foo", subrouter())

http.ListenAndServe(":3333", r)

}

func subrouter() http.Handler {
r := chi.NewRouter()
r.Get("/bar", func(w http.ResponseWriter, r *http.Request) {
log.Println("/foo/bar")
})
return r
}
$ curl -v localhost:3333/foo

GET /foo HTTP/1.1
< HTTP/1.1 404 Not Found
Not Found
** Not found? I defined this route -- and none path should rewrite it. **

$ curl -v localhost:3333/foo/

GET /foo/ HTTP/1.1
< HTTP/1.1 404 Not Found
404 page not found
* btw: Why's the body different compared to the previous request? Different NotFound handler?*

$ curl -v localhost:3333/foo/bar

GET /foo/bar HTTP/1.1
< HTTP/1.1 200 OK
/foo/bar
** OK **

—
Reply to this email directly or view it on GitHub.

[VojtechVitek]

Since I'm not overwriting the parent /foo path in the subrouter, I'd expect it to be matched and served anyways. Consider applying different middlewares for anonymous and auth'd routes from the parent router:

func main() {
    r := chi.NewRouter()

    r.Group(func(r chi.Router) {
        r.Use(InjectAnonymousToken)

        r.Get("/", PublicRoutes())
    })

    r.Group(func(r chi.Router) {
        r.Use(TokenRefresh)
        r.Use(Authenticator)

        r.Mount("/", AuthRoutes())
    })

    http.ListenAndServe(":3333", r)
}

It would be nice to be able to "merge" subrouters having a common root path.

[VojtechVitek]

Another example:

1. THIS WORKS (subrouter first, GetHandler route merges into the routes):

func main() {
    r := chi.NewRouter()

    // Auth'd routes
    r.Group(func(r chi.Router) {
        r.Use(TokenRefresh)
        r.Use(Authenticator)

        r.Mount("/", AuthRoutes())
    })

    // Public routes
    r.Group(func(r chi.Router) {
        r.Use(InjectAnonymousToken)

        r.Get("/", GetHandler)
    })

    http.ListenAndServe(":3333", r)
}

2. THIS DOESN'T WORK (subrouter second, it overrides the GetHandler route w/o merge):

func main() {
    r := chi.NewRouter()

    // Public routes
    r.Group(func(r chi.Router) {
        r.Use(InjectAnonymousToken)

        r.Get("/", GetHandler)
    })

    // Auth'd routes
    r.Group(func(r chi.Router) {
        r.Use(TokenRefresh)
        r.Use(Authenticator)

        r.Mount("/", AuthRoutes())
    })

    http.ListenAndServe(":3333", r)
}