http.Handler vs http.HandlerFunc

[go-chi]

http.Handler vs http.HandlerFunc

[nubunto]

Since http.HandlerFunc implements http.Handler, shouldn't all the method functions take an http.Handler instead? This is probably a stretch WRT compatibility, but it would make more sense to structure chi routers around interfaces, rather than around functions.

[pkieltyka]

@didip yea, I'd rather not do that.. I want to keep Router interface simpler/smaller.

[mrcpvn]

Hi,
as a workaround you can set up the route like this:

chi.NewRouter().Get(http.HandlerFunc(yourHandler.ServeHTTP))

[pkieltyka]

hey @didip - yea you can do:chi.NewRouter().Get(yourHander.ServeHTTP)

[didip]

Oh, TIL, they can be casted back and forth. This works too: handler.(http.HandlerFunc).

Thanks for taking the time!

But that said (I am just opening a discussion here), what do you guys think about having GetFunc and Get as new API? It seems cleaner.

[dvelitchkov]

This seems like a giant mistake - to tie the methods' first parameter to http.HandlerFunc and not http.Handler. You want the parameter to be an interface type, not a specific implementation of that interface. Same reason why fmt.Fprint* take an io.Writer, not os.Stdout. Any chance this can be fixed in v5? v6?

[pkieltyka]

@dvelitchkov I hear you, but the common case is to attach a func SomeHandler(w http.ResponseWriter, r *http.Request) { .. } method to an endpoint, if I change the parameter to a http.Handler it will require everyone to write, r.Get("/path", http.HandlerFunc(SomeHandler)) which I don't think is better. It's been decided for syntactic sugar reasons this is the more common case.