Configurable logger middleware

[go-chi]

Configurable logger middleware

[pkieltyka]

hey @mvdan thanks man, we've worked hard to keep middleware lean and robust.

I agree the middleware logger doesn't fit all needs, especially lacking structured logging. The nice thing about chi is that its fully compatible with the stdlib, and any other handler or middleware in the ecosystem that as well uses just the stdlib, that is http.Handler or func(http.Handler) http.Handler and r.Context() from *http.Request. Therefore you could write a logger in any repo, and it would 'just work' in chi, as well work perfectly well for any other Go project that uses vanilla http.Handler's :)

So far, we have used https://github.com/goware as our "contrib" for chi, since its really not chi specific, nothing is chi specific, its Go net/http specific

[mvdan]

Oh, makes sense. In that case, I think the README should be modified to clarify that any net/http middleware will work with chi. Right now it only mentions chi middleware and lists middlewares developed alongside chi, so this wasn't obvious to me.

Thanks!

[pkieltyka]

Ok cool, thanks for the feedback, I'll make sure to clarify in the README

[pkieltyka]

@mvdan 2fb5424 -- please let me know if thats better and if there are other parts in the docs that could be better or parts you feel are missing or under-represented. thanks!