possible misuse of unsafe.Pointer in gasyncresult.go

[sirzooro]

possible misuse of unsafe.Pointer in gasyncresult.go

[RSWilli]

This is the line in question: https://github.com/go-gst/go-glib/blob/main/glib/gasyncresult.go#L86

[RSWilli]

The function in question is the following:

// IsTagged is a wrapper around g_async_result_is_tagged
func (v *AsyncResult) IsTagged(sourceTag uintptr) bool {
	c := C.g_async_result_is_tagged(v.native(), C.gpointer(sourceTag))
	return gobool(c)
}

The linter is complaining about a cast from the uintptr argument to a unsafe.Pointer via C.gpointer. go vet also catches this.

Related to #62

[RSWilli]

@sirzooro are you actively using the IsTagged function that gets reported? The only way to fix this is by changing the argument type, which will be a breaking change.

But the linters are correct, normally how it is now is already broken, these types of casts can lead to really fun to debug segmentation faults. That is why this wont be a major release in terms of semver

[sirzooro]

No, feel free to change it.

[RSWilli]

FYI this issue was autoclosed and is only actually completed with the merger of #75