registry: Registry flag in registry package

[go-micro]

registry: Registry flag in registry package

[asim]

Makes sense. I need to give some thought to the approach with flags and whether that's the right method for the library.

[asim]

I was speaking with @dancannon, he made me realise that flags in a library are probably bad practice. I'll look to remove flags entirely and provide an example of initialisation in the template project.

[crackcomm]

I understand that defining flags in library init function may be a bad practice, but in such libraries like service server (like this one) I think flags should be standarized. Please take a look at how kubernetes is defining server flags.

Edit:
Maybe define flags in Init()?

[asim]

The example given here is for the kubernetes master server which is not a library but a service itself. It would make sense to perhaps extract out flags into a separate package that could be used to run go-micro from the command line. The mistake was probably having flags in the server package in the first place. It should be imported for use elsewhere rather than the defacto starting point.

[asim]

Flags have been removed from the server package. I have created a new package called cmd for cli based usage which includes flag parsing. You can call import the cmd package and call cmd.Init() to parse flags and initialise the various packages based on that. This means if you are using the client or registry for your own uses you can use it for that too.

[crackcomm]

Now it really can be seen with a naked eye it's a better way.