multiple expectations on the same statement

[ddanurwenda]

multiple expectations on the same statement

[Fs02]

hmm, this package should be compatible with go-rel/rel/reltest, so this is a bug and needs to be fixed.

alternative way to fix that is, by specifying how many times the calls will happens:

	repo.ExpectTransaction(func(repo *Repository) {
		repo.ExpectInsert()
		repo.ExpectUpdate().Success().Times(1)
		repo.ExpectUpdate().ConnectionClosed()
	})

[Fs02]

looks like the missing feature from testify/mock is the ability to find a better mocks.
https://github.com/stretchr/testify/blob/acba37e5db06f0093b465a7d47822bf13644b66c/mock/mock.go#L321-L323

we should try to prioritize mocks based on:

• number of matched attributes (full match or partial match using any)
• type or table match
• repeatability and total calls (repeatability > 0 or totallCalls == 0 should be prioritized)

the last criteria should makes your test pass

[Fs02]

But looks like that implementation is too complex to be added here, too many possible mocks variations (struct, partial struct, table, type, query etc) in reltest matcher 🤔

My other idea is to make repo.ExpectUpdate().Success().Times(1) as default behavior, unless Many (repo.ExpectUpdate().Success().Many() is specified).

let me know if you have any thought

[ddanurwenda]

I always thought repo.ExpectX() without additional assertion is equal to repo.ExpectX().Success().Times(1), at least that's how I used go-rel/rel/reltest. I think setting it as default behavior is a good idea 👍

[Fs02]

Agree, let’s do that!

[Fs02]

this changes has been released as v0.4.0: https://github.com/go-rel/reltest/releases/tag/v0.4.0
sorry for the late release 🙏