Add support for automatic json unmarshalling using map on response

[moorara]

Add support for automatic json unmarshalling using map on response

[jeevatkm]

Sure, I will add support for map for JSON content type.

[jeevatkm]

@moorara - It seems resty already supports map type.

I have created this test case method for resty. Have a look and share your thought.

func TestPostJSONResultMapSuccess(t *testing.T) {
	ts := createPostServer(t)
	defer ts.Close()

	c := dc()
	c.SetDebug(false)

	resp, err := c.R().
		SetBody(map[string]interface{}{"username": "testuser", "password": "testpass"}).
		SetResult(map[string]interface{}{}).
		Post(ts.URL + "/login")

	assertError(t, err)
	assertEqual(t, http.StatusOK, resp.StatusCode())

	result := (*resp.Result().(*map[string]interface{}))
	fmt.Println("result[id]:", result["id"])
	fmt.Println("result[message]:", result["message"])
}

Also added dereferencing for your code snippet. It works.

resp, err := resty.R().SetResult(map[string]interface{}{}).Get(url)
result := (*resp.Result().(*map[string]interface{}))
fmt.Printf("%+v", result["message"])

[jeevatkm]

@moorara can you please share your feedback?

[jeevatkm]

@ChristianLohmann I saw thumps up for map support. Can you please see my above responses and share your feedback?

[ChristianLohmann]

Nice idea would appreciate to have. Is there also the demand of having slices marshaled to result? For me it would make sense to have response bodys like

[
  {
    "prop1": {},
    "prop2": "",
    "prop3": 1,
    "prop4": []
  }
]

automatically get unmarshaled to result.

[jeevatkm]

@ChristianLohmann - actually resty already supports map. Key point is; you have to dereference it before using a map.

resp, err := resty.R().SetResult(map[string]interface{}{}).Get(url)
result := (*resp.Result().(*map[string]interface{}))
fmt.Printf("%+v", result["message"])

I have tested at my end for map and Can you please try and let me know?

[jeevatkm]

Since resty already has map support, it just user have to deference it before use.

I'm closing it. Thanks @moorara @ChristianLohmann