Add support for go-logr/logr on resty

[thapabishwa-plerionaut]

Add support for go-logr/logr on resty

[halfcrazy]

+1 for this feature, especially for the kubernetes ecosystem

[jeevatkm]

@thapabishwa-plerionaut @halfcrazy Thanks for reaching out. I'm sorry for the delayed response.

Resty provides a Logger interface for user choice of overriding.

resty/util.go

Lines 31 to 35 in 97187c4

	type Logger interface {
	Errorf(format string, v ...interface{})
	Warnf(format string, v ...interface{})
	Debugf(format string, v ...interface{})
	}

So you could assign your existing logger instance to it.

client := resty.New().SetLogger(...)

[thapabishwa]

@jeevatkm

The interface you mentioned doesn't have the ability to interoperate with loggers(like gologr, klog, slog etc) that are used in kubernetes ecosystem.

package main

import (
	"net/http"

	"github.com/go-resty/resty/v2"
	"sigs.k8s.io/controller-runtime/pkg/log"
)

func main() {

	logger := log.Log.WithName("controller").WithName("mylogger")
        /// cannot use logger (variable of type logr.Logger) as resty.Logger value in argument to resty.New().SetLogger: logr.Logger does not implement resty.Logger (missing method Debugf)
	client := resty.New().SetLogger(logger)
	cookies := []*http.Cookie{
		&http.Cookie{
			Name:  "go-resty-1",
			Value: "This is cookie 1 value",
		},
		&http.Cookie{
			Name:  "go-resty-2",
			Value: "This is cookie 2 value",
		},
	}

	client.SetCookies(cookies)

}

[jeevatkm]

logr.Logger does not implement resty.Logger (missing method Debugf)

@thapabishwa Based on the error message, it seems logr does not have a Debugf implementation. I suggest creating a tiny wrapper for the log library you would like to use.

For example, refer to -

resty/util.go

Lines 37 to 66 in 94e70d3

	func createLogger() *logger {
	l := &logger{l: log.New(os.Stderr, "", log.Ldate|log.Lmicroseconds)}
	return l
	}
	var _ Logger = (*logger)(nil)
	type logger struct {
	l *log.Logger
	}
	func (l *logger) Errorf(format string, v ...interface{}) {
	l.output("ERROR RESTY "+format, v...)
	}
	func (l *logger) Warnf(format string, v ...interface{}) {
	l.output("WARN RESTY "+format, v...)
	}
	func (l *logger) Debugf(format string, v ...interface{}) {
	l.output("DEBUG RESTY "+format, v...)
	}
	func (l *logger) output(format string, v ...interface{}) {
	if len(v) == 0 {
	l.l.Print(format)
	return
	}
	l.l.Printf(format, v...)
	}