int64 -> *sql.RawBytes Scan error

[go-sql-driver]

int64 -> *sql.RawBytes Scan error

[hgfischer]

FYI: I've had to fork and reset to beta3 to make it work again. I plan to delete my fork when this is fixed.

[julienschmidt]

While the database/sql package is able to convert from int* -> *string, it is unable to convert to *[]byte. This is not specific to *sql.RawBytes. Also this is not a driver issue.

Before beta 4 this driver returned every value as []byte. For int* values this means converting the []byte (Little Endian representation) from the stream to an integer value, formatting it as a string and return the string as []byte (string representation this time) again, which obviously has a lot of overhead.

According to the database/sql/driver specification it is completely fine to return an int64 value.
So we can skip the string formatting an converting string -> []byte part.
Therefor this is an driver/sql package issue. I'm working on a fix anyways.

For all that, your query should work fine in go tip / Go 1.1, where the Queryer driver interface is available. This allows this driver to run queries without args with the MySQL text protocol (In Go 1 every query must use prepared statements, which use the binary protocol) where everything is already returned in string representation, which is why everything is still returned as a []byte value.

[julienschmidt]

Hotfix for $GOROOT/src/pkg/database/sql/convert.go (Go 1.0.3)

Patch: http://files.julienschmidt.com/public/gostuff/convert.go.patch
Fixed File: http://files.julienschmidt.com/public/gostuff/convert.go

After replacing delete the folder $GOROOT/pkg/<arch>/database/ and run go test -i in $GOROOT/src/pkg/database/sql/ then

I send out a CL for go later. I'm on my Notebook. I must set up gcc + hg + codereview tool first :)

[hgfischer]

👍 Thank you for all the explanation, the patch, and your time! 💯

I'll probably wait for Go 1.1 to get back using to your repo since I don't need too much performance for my small tool right now and Go 1.1 is right near the corner.

[julienschmidt]

https://codereview.appspot.com/7783046

[arnehormann]

Merged in tip since devel +1ec96e11707f, yay!!!

[hgfischer]

👍 congratz!