Giter Site home page Giter Site logo

Comments (3)

Zireael07 avatar Zireael07 commented on August 15, 2024 2

Unless the original issue title is outright wrong and/or misspelled, the title isn't changed

from godot.

AThousandShips avatar AThousandShips commented on August 15, 2024 1

From the code this is intended, and is vaguely hinted at in the animation_changed signal, but should be more clear:

if (end_reached) {
if (queued.size()) {
String old = playback.assigned;
play(queued.front()->get());
String new_name = playback.assigned;
queued.pop_front();
if (end_notify) {
emit_signal(SceneStringNames::get_singleton()->animation_changed, old, new_name);
}
} else {
//stop();
playing = false;
_set_process(false);
if (end_notify) {
emit_signal(SceneStringNames::get_singleton()->animation_finished, playback.assigned);
}
}
end_reached = false;
}

from godot.

aaandreeew avatar aaandreeew commented on August 15, 2024

Hey, I'm new to the Godot issues system. I see we've added tags "documentation" and "enhacement", since the issue is unclear documentation causing unexpected behaviour, not incorrect behaviour.

Should the issue's title be changed to reflect this, too? Or is it standard to not modify the meaning of an issue name, only to simplify or clarify it?

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.