Comments (4)
Ah yes, I'll take a look.
This actually is an existing divide by zero vulnerability in the camera code that I noticed (if I remember right), which is a pretty serious error, and could have previously resulted in crashes / corruption.
Normal procedure is usually to flag these errors and recover / fix their source, rather than hide them. So this isn't really a regression, only the reporting of the error is new.
Will give more details when I examine the MRP.
This is the code I changed:
Point2 Camera::unproject_position(const Vector3 &p_pos) const {
...
// Prevent divide by zero.
// TODO : Investigate, this was causing Nans.
ERR_FAIL_COND_V(p.d == 0, Point2());
...
p.normal /= p.d;
from godot.
I've worked out the vulnerability, full details in the PR below.
from godot.
Fixed by #96032 (for 3.x), changing milestone for 4.x as needs to be closed there too (although it has not been reported in the wild).
from godot.
CC @lawnjelly
from godot.
Related Issues (20)
- Editor crashes when re-importing GLTF scene while Animation window is open HOT 1
- `GLES3` shadeless colors are incorrect compared to `Vulkan` [3D] HOT 5
- Can't import specific DDS textures HOT 1
- Editor crash after adding a point by intersecting the Curve2D line and undoing the change from the history. HOT 3
- Editor crashes when method parameter is constant value HOT 1
- The "Dock Position" window is visible after clicking on it.
- "!is_inside_tree()" error shows when inspecting imported WorldEnvironment's Environment resource that has certain settings enabled on Inspector tab
- OpenXR Composition Layer visibility on/off is not working on some circumstances
- Wayland Cursor custom Image don't show
- Emulate 3 Button Mouse is broken.
- Standalone expression "text.right(-50)" not caught by debugger HOT 2
- signal.emit() doesn't function properly when conditioned behind InputEvent & the Input gets set as handled HOT 3
- TileMapLayer destroys Tiles when detached from the tree HOT 2
- `scons` build fails on Windows with `core/os/keyboard.h: No such file or directory` HOT 8
- No longer able to export macOS builds as .app from Windows HOT 3
- AnimationTree -> StateMachine -> Animation calling audioplayer broken HOT 2
- Audio stutter/artifacts when lagging or overworking CPU HOT 2
- Reparenting RigidBody2D with physics interpolation enabled causes ghosting
- C# Custom RichTextEffect Not in Dropdown HOT 2
- No option to disable shadow blur for StyleBoxFlat HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godot.