default

[gogo]

default

[awalterschulze]

From awalterschulze on October 31, 2013 23:56:49

gogoprototests are done.

Making default values illegal for non-nullable fields might fix all my issues. https://code.google.com/p/gogoprotobuf/source/detail?r=321219d70bc26ad10c2ada5d148ea122473f4ac3 I should also make sure fieldpath works with defaults.

[awalterschulze]

From awalterschulze on November 01, 2013 00:04:31

I reverted changes which will make default and nullable work together https://code.google.com/p/gogoprotobuf/source/detail?r=53f1868722b1474411bf22f1cc69cd4a3b73f0b6 I see potential problems when unmarshalMerge comes around and and the default values override the already set values.
With non-nullable fields it is "hard" to tell if they have been set before.

I finally understand this

"Project Member #5 [email protected]:
Protocol buffers specify that it is possible to distinguish between a
field being set and a field having its default value, as bizarre as
that may seem. Thus a plain value is not sufficient representation,
and we decided that pointers were the least of the possible evils.
" - https://code.google.com/p/goprotobuf/issues/detail?id=29&can=1 I would rather not make nullable more popular than it needs to be.
So if it means that nullable has limited use cases this is good thing.

[awalterschulze]

From awalterschulze on November 01, 2013 00:58:42

This eliminated all of the problems I could see, except fieldpath https://code.google.com/p/gogoprotobuf/source/detail?r=96cc1417d78d7a5e57fa659342fe9d6332761e0b

[awalterschulze]

From awalterschulze on November 01, 2013 06:22:20

https://code.google.com/p/gogoprotobuf/source/detail?r=a2cbb9e3ce8ab9e350516a3cda5da7b61f926853 Finally fixed

Status: Fixed