support pull_request_review event type for only-new-issues

[humancalico]

support pull_request_review event type for only-new-issues

[ldez]

Golangci-lint is already triggered when a PR is created or updated.

Documentation about pull_request_review event.

---

• prevent any malicious code from triggering your GitHub Actions

This should be handled inside the GitHub repository configuration.
https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

---

• cuts down the total billable minutes (since you're only running lints on pull request approvals and not on every update to the PR)

This only applies to private repositories so your first argument doesn't fit.
Anyway, pull_request_review is not for approval but for reviews.

Even if you restrict only on approval (i.e. submitted + if: github.event.review.state == 'APPROVED'), this means you will approve a PR without having the result of the linting, this doesn't make sense.

If you think of another activity type (ex: edited), it's the same thing but worse.

To cut down the total billable minutes:

• run golangci-lint locally before a push (and before a commit), the cache will do the job.
• don't push half-done work

---

You want to launch golangci-lint on demand but your proposal (pull_request_review) is a bad approach.

[humancalico]

You want to launch golangci-lint on demand but your proposal (pull_request_review) is a bad approach.

@ldez Would love to hear any alternatives you have in mind