Action is causing deprecation warnings

[golangci]

Action is causing deprecation warnings

[jannfis]

After a little more research, the issue seems to stem from something in the cache (in the prepare-environment step of the golangci-lint-action):

  Finding needed golangci-lint version...
  Setup go stable version spec 1
  Found in cache @ /opt/hostedtoolcache/go/1.15.2/x64
  Warning: The `set-env` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
  Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
  Added go to the path
  Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
  Successfully setup go version 1
  go version go1.15.2 linux/amd64

So, maybe bumping up a cache version somewhere to invalidate old stuff might be the correct fix.

[jannfis]

🎉 Now it doesn't generate the deprecation notices anymore! Thank you for the quick support 👍

[sayboras]

I think it's used internally in one of dependency (e.g. actions/*), currently latest version is used based on my understanding.

A quick grep for both set-env and add-path didn't help much, do you have do any specific place ?

[sayboras]

Please upgrade to the latest version v2.2.1, sample run is available here https://github.com/golangci/golangci-lint/runs/1261488064

> prepare environment
  Finding needed golangci-lint version...
  Setup go stable version spec 1
  Found in cache @ /opt/hostedtoolcache/go/1.15.2/x64
  Added go to the path
  Successfully setup go version 1
  go version go1.15.2 linux/amd64

[jannfis]

Ah, I was under the impression that the @v2 specified as the action's version would always use the latest version from the 2.x branch.

So if I understood your pointer correctly, we shall replace uses: golangci/golangci-lint-action@v2 with uses: golangci/[email protected]?

[sayboras]

currently, v2 is pointing to v2.0 or v2.1 only I think. I think github action convention is to tag only major version, which I don't prefer personally :).

Let me point v2 to v2.2.1 shortly, it was pending action in my note while released v2.2.1 recently. Thanks for reminder 💯

[sayboras]

Done, now v2 points to latest release v2.2.1.