Giter Site home page Giter Site logo

Comments (10)

azisaka avatar azisaka commented on August 18, 2024 9

while we don't get a new version you can replace uses: golangci/golangci-lint-action@v3 by uses: golangci/golangci-lint-action@master

from golangci-lint-action.

rhussmann avatar rhussmann commented on August 18, 2024 5

@178inaba one more workaround that doesn't depend on a moving ref

uses: golangci/golangci-lint-action@c67416616c29c3c48d26b59c45cadb56966d80aa

where c67416616c29c3c48d26b59c45cadb56966d80aa is the full commit SHA where action.yml was updated to point to node20.

Still looking forward to seeing a persistent tag published with this support as I'd prefer not to have to rely on a specific commit.

from golangci-lint-action.

ldez avatar ldez commented on August 18, 2024 3

Done https://github.com/golangci/golangci-lint-action/tags
v3 updated and v3.7.1 created.

from golangci-lint-action.

178inaba avatar 178inaba commented on August 18, 2024 2

@azisaka
Thank you for the reply! I also considered that approach, but it seems that specifying branches is not recommended in the Actions documentation.

Using the default branch of an action may be convenient, but if someone releases a new major version with a breaking change, your workflow could break.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses

Under this release management approach, users should not be referencing an action's default branch, as it's likely to contain the latest code and consequently might be unstable. Instead, you can recommend that your users specify a major version when using your action, and only direct them to a more specific version if they encounter issues.
https://docs.github.com/en/actions/creating-actions/about-custom-actions#good-practices-for-release-management

from golangci-lint-action.

ldez avatar ldez commented on August 18, 2024 2

Sorry, I will create a v4 and try to restore the previous v3.

from golangci-lint-action.

ldez avatar ldez commented on August 18, 2024 2

I moved the tag v3 to v3.7.0 and created v4 and v4.0.0

I'll keep v3.7.1 to avoid being too breaking.

from golangci-lint-action.

178inaba avatar 178inaba commented on August 18, 2024 1

@ldez Thanks!

from golangci-lint-action.

lukestoward avatar lukestoward commented on August 18, 2024 1

@ldez ideally this change should have been a new major version aligning with how other standard actions managed the upgrade. See actions/cache, actions/setup-go etc.

This has broken our pipeline as a result, as Node 20 requires newer GLIBC versions. Easily fixed, but we will have to pin the version to v3.7.0 now instead of using @v3.

from golangci-lint-action.

lukestoward avatar lukestoward commented on August 18, 2024 1

Great, thanks for the quick resolution!

from golangci-lint-action.

ldez avatar ldez commented on August 18, 2024

Hello,

I will create a new release in a few minutes.

from golangci-lint-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.