Comments (10)
while we don't get a new version you can replace uses: golangci/golangci-lint-action@v3
by uses: golangci/golangci-lint-action@master
from golangci-lint-action.
@178inaba one more workaround that doesn't depend on a moving ref
uses: golangci/golangci-lint-action@c67416616c29c3c48d26b59c45cadb56966d80aa
where c67416616c29c3c48d26b59c45cadb56966d80aa
is the full commit SHA where action.yml
was updated to point to node20
.
Still looking forward to seeing a persistent tag published with this support as I'd prefer not to have to rely on a specific commit.
from golangci-lint-action.
Done https://github.com/golangci/golangci-lint-action/tags
v3 updated and v3.7.1 created.
from golangci-lint-action.
@azisaka
Thank you for the reply! I also considered that approach, but it seems that specifying branches is not recommended in the Actions documentation.
Using the default branch of an action may be convenient, but if someone releases a new major version with a breaking change, your workflow could break.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses
Under this release management approach, users should not be referencing an action's default branch, as it's likely to contain the latest code and consequently might be unstable. Instead, you can recommend that your users specify a major version when using your action, and only direct them to a more specific version if they encounter issues.
https://docs.github.com/en/actions/creating-actions/about-custom-actions#good-practices-for-release-management
from golangci-lint-action.
Sorry, I will create a v4 and try to restore the previous v3.
from golangci-lint-action.
I moved the tag v3 to v3.7.0 and created v4 and v4.0.0
I'll keep v3.7.1 to avoid being too breaking.
from golangci-lint-action.
@ldez Thanks!
from golangci-lint-action.
@ldez ideally this change should have been a new major version aligning with how other standard actions managed the upgrade. See actions/cache, actions/setup-go etc.
This has broken our pipeline as a result, as Node 20 requires newer GLIBC versions. Easily fixed, but we will have to pin the version to v3.7.0
now instead of using @v3
.
from golangci-lint-action.
Great, thanks for the quick resolution!
from golangci-lint-action.
Hello,
I will create a new release in a few minutes.
from golangci-lint-action.
Related Issues (20)
- typecheck error is not resulting in useful annotation HOT 2
- annotations display on 2 PR (develop and staging, although I don't run golangci-lint in staging) HOT 1
- "File exists" errors when un-taring golangci-lint on upgrading to setup-go@v4 from setup-go@v3 HOT 4
- lint failures do not report which file or line failed HOT 4
- Add support for `new-from-rev` HOT 3
- bug: The file exists in scripts/golangci.yml, but it still gives an error HOT 1
- buildir: failed to load package pebble: could not load export data: no export data for "github.com/ethereum/go-ethereum/ethdb/pebble"
- caches: Do we really need them anymore? The current implementation conflicts with automatic caching in latest `setup-go`. HOT 4
- typecheck fails on first CI run HOT 6
- Incompatibility with go 1.21 HOT 1
- Panic HOT 1
- Make only-new-issues work with Merge Queues, not just Pull Requests HOT 9
- Action output not helpful HOT 6
- Node.js 16 actions are deprecated HOT 2
- tags v3.7.1 / v4 / v4.0.0 but no release HOT 2
- Add release notes for v4.0.0 HOT 1
- bump action runtime to `node20` HOT 1
- Execution time takes too long with deafult GO111MODULE=on HOT 3
- cache upload hangs for 2 minutes after work is done HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from golangci-lint-action.