Giter Site home page Giter Site logo

Comments (2)

kde3kko avatar kde3kko commented on June 27, 2024 1

I've stumbled into this problem today, and i've spent 4 hours straight debugging my own code, trying to understand why the init was resolving in Android but not on iOS.
I then took a look inside the plugin code...
The java implementation does indeed work correctly as a promise, while in the obj-C code the resolve parameter is never executed at all:

RCT_EXPORT_METHOD(init: (NSString *)consumerKey consumerSecret:(NSString *)consumerSecret resolver:(RCTPromiseResolveBlock)resolve  
rejecter:(RCTPromiseRejectBlock)reject)
{
    [[Twitter sharedInstance] startWithConsumerKey:consumerKey consumerSecret:consumerSecret];
}

I assume this is wrong, as the js interface should be identical between the two platforms.
Let me know if I can be of any help.

from react-native-twitter-signin.

jslz avatar jslz commented on June 27, 2024

+1 I think this is confusing at least, and maybe buggy at worst.

https://github.com/facebook/react-native/blob/master/React/Base/RCTBridgeModule.h#L133

https://github.com/GoldenOwlAsia/react-native-twitter-signin/blob/master/ios/RNTwitterSignIn.m#L23

The init() should invoke the resolve or reject, or should be written to not look like it uses promises at all?

from react-native-twitter-signin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.