lapack: review type and constant declarations

[vladimir-ch]

lapack: review type and constant declarations

[vladimir-ch]

Looking at DGEEV, its list of parameters starts with

*> \param[in] JOBVL
*> \verbatim
*>          JOBVL is CHARACTER*1
*>          = 'N': left eigenvectors of A are not computed;
*>          = 'V': left eigenvectors of A are computed.
*> \endverbatim
*> \param[in] JOBVR
*> \verbatim
*>          JOBVR is CHARACTER*1
*>          = 'N': right eigenvectors of A are not computed;
*>          = 'V': right eigenvectors of A are computed.
*> \endverbatim

Using lapack.Job for both parameters seems dangerous:

const (
   ComputeLeftEigVec Job = 'V'
   ComputeRightEigVec Job = 'V'
)

because they would be interchangeable without the compiler complaining. This led me to believe that we should probably avoid using generic Job and Comp types in native and cgo which leads me to ask whether we need to use lapack.Job and lapack.Comp in the lapacke package. If its sole purpose is to serve the cgo package, then using just byte would be enough and lapacke wouldn't need to import lapack.