Update lodash version

[google-fabric]

Update lodash version

[axelson]

+1 to this so that I don't need an extra copy of lodash in my distributed bundle

[fionawhim]

Are you doing some top-level aliasing shenanigans with webpack? If npm is well-behaved, it will put lodash in a node_modules directory relative to velocity-react, and that's what the velocity-react package will import. The velocity-react imports are already directly to lodash files, so it doesn't rely on tree-shaking or anything along those lines.

…

On Mon, Aug 28, 2017 at 8:12 PM Aaron Melocik ***@***.***> wrote: @finneganh <https://github.com/finneganh> -- I'm also having this Lodash issue, though I'm not 100% confident that it's velocity-react (50/50 chance at this point). But regarding the explicit imports in Lodash and webpack only requiring the necessary modules -- I don't think you get that for free with Webpack. My understanding is that if you were to import all of your lodash statements namespaced, i.e.: import { merge } from 'lodash'; ... then Webpack would, as part of optimizing the dependency graph, only create a module out of merge. But if you import all of lodash, i.e.: import _ from 'lodash'; ... then you've got all of lodash coming your way. You can validate the weight of lodash in velocity-react using the bundle-analyzer-tool: https://github.com/th0r/webpack-bundle-analyzer — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAP65b9L7kcth772SD0zGvspodNvG3kmks5sc1digaJpZM4HjHTQ> .

[fionawhim]

Presumably we could upgrade to 4, though I don't see why you'd be getting an error now. In my tests, NPM installed lodash 3.10 into velocity-react's node_modules folder.

You may need to wipe your node_modules directory and do a re-install to get that, though.

[BLMaster]

Yeah you're right..
I got the error when upgraded the package.
Reinstalling velocity-react will solve it..

Thanks!

[fionawhim]

Not sure what the error is… we're pegged to the 3.10 implementation.

[TCMiranda]

It seems that the only problem is the "namespace" isn't it?
From: lodash/lang/isEqual
To: lodash/isEqual

Pluck has been deprecated also, will it be hard to upgrade?

[luisherranz]

+1 to this so that I don't need an extra copy of lodash in my distributed bundle

True!

[fionawhim]

Note that velocity-react doesn't require all of lodash, just a handful of functions. So, you're not getting a full extra copy in your bundle.

[eddiemonge]

Then why not only require the lodash packages you are using?

[fionawhim]

The components that use lodash are already only requiring/importing the particular methods that they need.

…

On Tue, Aug 1, 2017 at 4:50 PM Eddie Monge ***@***.***> wrote: Then why not only require the lodash packages you are using? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAP65VKRTKf_NOCqp2SQmLV8VjVXj6vjks5sT4-CgaJpZM4HjHTQ> .

[eddiemonge]

Not really. All of lodash is still included. This only installs the ones that are actually used: #219

[fionawhim]

My understanding is that a bundler such as webpack is only going to pull in the directly-required files (and their transitive dependencies), regardless of what's in node_modules, so I don't know what that PR gains.

…

On Tue, Aug 1, 2017 at 5:22 PM Eddie Monge ***@***.***> wrote: Not really. All of lodash is still included. This only installs the ones that are actually used: #219 <#219> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAP65cxOMAuLwqxRosxnqVzGdVZdN8Jaks5sT5cNgaJpZM4HjHTQ> .

[eddiemonge]

It gains not having to install all of lodash since its a dependency and gets installed when this does. Its not only about the production environment but also dev. Faster installs, less file size overhead. Why not be explicit?

[SterlingVix]

@finneganh -- I'm also having this Lodash issue, though I'm not 100% confident that it's velocity-react (50/50 chance at this point). But regarding the explicit imports in Lodash and webpack only requiring the necessary modules -- I don't think you get that for free with Webpack.

My understanding is that if you were to import all of your lodash statements namespaced, i.e.:

import { merge } from 'lodash';

... then Webpack would, as part of optimizing the dependency graph, only create a module out of merge.

But if you import all of lodash, i.e.:

import _ from 'lodash';

... then you've got all of lodash coming your way.

You can validate the weight of lodash in velocity-react using the bundle-analyzer-tool:

https://github.com/th0r/webpack-bundle-analyzer

To get Webpack to optimize your lodash build, you need to run a Babel transform:

https://www.npmjs.com/package/babel-plugin-lodash