Giter Site home page Giter Site logo

Comments (3)

dmah42 avatar dmah42 commented on May 21, 2024

I'm trying to think what the right solution is here.

Maybe benchmark should explicitly depend on glog and use the macros from there directly.

Another option is to check if they're defined before defining them.

I think I prefer the first, but I'm open to other thoughts!

from benchmark.

ckennelly avatar ckennelly commented on May 21, 2024

Is it even necessary to export the CHECK_XXX macros at all in the header file? These are being used internally rather than in benchmark.h.

from benchmark.

dmah42 avatar dmah42 commented on May 21, 2024

They are used in benchmark_test.cc which doesn't (yet!) depend on googletest. Maybe it should ;)

from benchmark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.