Comments (3)
I'm trying to think what the right solution is here.
Maybe benchmark should explicitly depend on glog and use the macros from there directly.
Another option is to check if they're defined before defining them.
I think I prefer the first, but I'm open to other thoughts!
from benchmark.
Is it even necessary to export the CHECK_XXX macros at all in the header file? These are being used internally rather than in benchmark.h
.
from benchmark.
They are used in benchmark_test.cc which doesn't (yet!) depend on googletest. Maybe it should ;)
from benchmark.
Related Issues (20)
- [BUG] Missing `\n` at the End of Console Output HOT 2
- [FR] Enforce CMake to find PFM or fail when `BENCHMARK_ENABLE_LIBPFM` is `ON` HOT 2
- [BUG] QNX compilation failure on v1.8.3. Patch suggestion. HOT 2
- [BUG] mismatch of macro name for cmake
- [FR] Define HOST_NAME_MAX for z/OS HOT 1
- [FR] Add z/OS case to ThreadCPUUsage to avoid error HOT 1
- [BUG] fail to import gbench into compare.py with bazel and python3.12
- [FR] Large File Support HOT 5
- [FR] Support Win32 on Windows HOT 1
- [BUG] Console created through AllocConsole does not receive colored output HOT 3
- [BUG] Result of run with --benchmark_list_tests=true may not show on console
- [FR] JSON AoS<->SoA redesign HOT 6
- Migrate to bzlmod HOT 9
- [BUG] 1.8.3: build fails with gcc 14.x HOT 4
- [FR] Add `CMake` option to disable `benchmark_main` target HOT 2
- [BUG] Weird behavior of bytes_per_second and items_per_second HOT 8
- [FR] cp312 release on pypi
- [BUG] Reported iterations per run when using repetitions always the same value? HOT 3
- [BUG] With NDEBUG, early-returning without SkipWithError leads to indefinite retries HOT 5
- Complexity calculation does not work for manual timing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from benchmark.