String.size() definition is ambiguous

[google]

String.size() definition is ambiguous

[TristonianJones]

This was fun! Can I steal you two permanently?

…

On Tue, Dec 18, 2018, 4:19 PM Tyler Rockwood ***@***.*** wrote: Closed #33 <#33>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdf5IgASbjzUh4xhNg8Cwu0924k5UALks5u6YYhgaJpZM4ZYsb8> .

[TristonianJones]

The spec should be updated to only use sequences of Unicode code points. This is the most intuitive to the eye and probably what the user would expect.

Would you mind filing a bug (or doing a PR) for the common/types/string.go Size() function, it should be using len([]rune(str)).

[JimLarson]

Fixed the misleading word in the spec (commit 1438598). Updating the cel-go implementation.

[ryanpbrewster]

I assume this change means that str[2] should return the third unicode codepoint, rather than the codepoint starting at the third byte?

[JimLarson]

We don't currently support indexing on strings in the CEL language, but if we did, then absolutely.

[rockwotj]

Thanks all!