Comments (14)
I only care about the license of the images. If there's no license problems, you can choose anything you want.
from chromeos-filesystems.
Okay, well I'm not a lawyer but from Amazon's guidelines it looks like we're okay using the logo like this.
As for WebDAV I reckon just go with the word 'DAV' since the official logo is so bad.
If that's all the legal stuff covered, all we need to do is ask a designer to work on them. I could give it a try but I don't have Photoshop on my work machine and it wouldn't look as professional.
from chromeos-filesystems.
I'm not a lawyer but if the guideline is so, I think that's fine. Also I heard that you drew the s3 icon by yourself. Then, no problem I guess.
For s3, I'm okay with ugly-but-official one, but if you're not, you can draw the icon by yourself.
from chromeos-filesystems.
Note that AWS SDK's git repository contains the amazon badge https://github.com/aws/aws-sdk-js/blob/master/doc-src/templates/flasky_sphinx_guide/fulldoc/html/img/logo.png licensed under apache-2.0.
from chromeos-filesystems.
Is there any way to specify separate icons for the Files app and the extension page? If not, I'd like to suggest that as a feature of the manifest.
The greyscale icons within a folder look good in the sidebar of the Files app, but they look kind of bad and also don't make much sense in the extensions list and app launcher. I think it would be better if you could specify a main logo, which would probably be full colour and just the icon, as well as the Files app icon, which is smaller, greyscale and has the icon within a folder icon like Google Drive does already.
I guess if we're going with the plan of making providers extensions instead of packaged apps then a regular display icon won't be necessary, but right now I think you still need to provide a 128px one.
from chromeos-filesystems.
I guess I could just have colour icons for 128px and 48px and greyscale folder ones for 32px and 16px.
from chromeos-filesystems.
I believe an iconset should have the consistent look. Doing 32px and 16px for filesystems UI doesn't sound a good idea.
from chromeos-filesystems.
But it's more important for icons to be consistent with the other icons around them. All the icons in the Files app are greyscale, and all the icons in the app launcher are full colour.
Think of Google Drive as an analogy. In the app launcher you expect to see this:
But in the Files app you expect to see this:
That's what I've done here: consistent elements, like the S3 logo or the word 'DAV', but different styles for different contexts.
from chromeos-filesystems.
That sounds like a feature request to fileSystemProvider API. File a bug instead of introducing a hack.
from chromeos-filesystems.
That's why I CC'ed @mtomasz-chromium, to ask if this feature could be added. I will open a crbug too. The hack was only ever meant to be a temporary solution, in lieu of an official method.
from chromeos-filesystems.
from chromeos-filesystems.
IMHO, real colorful icons should be shown for provided extensions. The icon
should tell users that the file system is provided by an extension with
that specific icon. Drive icon may change in the future in Files app if we
switch to FSP. However, it is not decided, yet.
On 27 August 2014 07:48, Giles Lavelle [email protected] wrote:
crbug.com/407864
—
Reply to this email directly or view it on GitHub
#39 (comment)
.
from chromeos-filesystems.
As per the discussion on the Chromium issue tracker, we will be using full-colour icons in the Files.app too. Do I need to supply 24px as well as 48 for this then?
from chromeos-filesystems.
You don't have to. IIRC images are automatically resized by Chrome if requested size doesn't exist.
from chromeos-filesystems.
Related Issues (20)
- Update truncate method name
- Refactor out chrome mock
- Comment all Gruntfile tasks
- Ways to mock the S3 API HOT 1
- bowerjs
- what is this for HOT 1
- Feature Request: add startIn attribute for ChooseEntry
- Write operations behaviour questions HOT 1
- Challenges with S3 and Write operations
- Can't get WebDAV copy to work HOT 3
- Update new write operations to assign to a variable before exporting to JSDoc can pick them up
- S3FS onWriteFileRequested JSDoc description is wrong
- Write events are not actually registered with the filesystem
- Add lint task for CI
- Condense S3 events into one file
- WebDAV onWriteFileRequested JSDoc is wrong
- Reset filesystem between every test run HOT 2
- Remove Makefiles
- Tidy up WebDAV events file
- Add error handling for S3 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chromeos-filesystems.