Giter Site home page Giter Site logo

Comments (2)

ianlewis avatar ianlewis commented on August 16, 2024

@sarahmaddox Thanks for the issue. Sorry about the error.

I think what is happening is that it's picking up the logo-jupyter.svg or logo-tensorflow.svg and trying to resize it but since it's svg it can't be resized.

The change I made in #16 was intended to act like the support for **background* image by looking for an image file that matches **logo*. A workaround would be rename the svg files to not include "logo" in the file name.

I'm open to better ways to add a logo image in the cover block that aligns with other support for images. Kubeflow's website uses support for a logo in the navbar but it's limited to svg currently:

<span class="navbar-logo">{{ with resources.Get "icons/logo.svg" }}{{ ( . | minify).Content | safeHTML }} {{ end }}</span><span class="text-uppercase font-weight-bold">{{ .Site.Title }}</span>

I'll be sure to test PRs w/ kubeflow's website in the future too.

from docsy.

sarahmaddox avatar sarahmaddox commented on August 16, 2024

Thanks @ianlewis that works. I've created a PR to change the image names in the Kubeflow repo.

from docsy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.