Comments (12)
Ok, I'll attempt a patch.
from double-conversion.
I added the -Wzero-as-null-pointer-constant
flag to the build and didn't see any warnings.
Would it not be safe to just add the warning?
from double-conversion.
That's surprising because this repo does not contain the string nullptr
: https://github.com/google/double-conversion/search?q=nullptr When I build, I do get such warnings from clang.
from double-conversion.
@floitsch maybe you need to explicitly specify a newer C++ version with say -std=c++17
for the warning flag to do anything.
But the question remains: What is the minimum C++ dialect this project supports?
from double-conversion.
I must have done something wrong.
Tried again (this time with clang) and now I get warnings.
I never really thought about a minimum version, but I guess C++11 is fine.
Really a pity, that one can't just #define NULL nullptr
...
from double-conversion.
many other projects do something like:
#if __cplusplus >= 201103L
# define DC_NULLPTR nullptr
#else
# define DC_NULLPTR NULL
#endif
from double-conversion.
I think that's an acceptable solution.
In my new project we now use null
:
constexpr std::nullptr_t null = nullptr;
I think something like that should work here too. (together with the #ifdef
when it's not available).
from double-conversion.
Is there a .h file already included everywhere, where this can be put?
from double-conversion.
I don't think there is one yet.
Maybe utils.h
.
For simplicity I would put it there, since it's already included in most other sources.
from double-conversion.
Sorry, didn't anticipate needing a lawyer. :(
Hopefully someone else can fix the warnings.
Cheers.
from double-conversion.
The project was created while I worked at Google. This bot is a requirement there. (Tbh, probably for good reasons).
That said: I can override the bot if the changes are small enough.
If you reopen the PR I can commit it.
from double-conversion.
The project was created while I worked at Google. This bot is a requirement there. (Tbh, probably for good reasons).
No doubt, but I've made this patch on my employer's time, which technically means involving them, which becomes complicated as you can imagine.
That said: I can override the bot if the changes are small enough.
If you reopen the PR I can commit it.
Done, thanks!
from double-conversion.
Related Issues (20)
- Maximum string length DoubleToStringConverter::EcmaScriptConverter() ToShortest? 26 chars? HOT 8
- kMaxFixedDigitsAfterPoint should be increased from 60 to 100 HOT 2
- StringToDoubleConverter::StringToDouble slower than dtoa HOT 3
- `StringToDoubleConverter::StringTo<FloatingPoint>` member function templates HOT 3
- Add generic (template) methods for `to_string` (float or double). HOT 2
- New tag/version since 2019? HOT 2
- [bug] ieee.h: Wrong QuietNaN bit check on mips* architectures HOT 1
- Kindly add installation of Windows debugger files (pdb)? HOT 5
- FastFixedDtoa incorrect rounding. HOT 1
- Tag a v3.2.1 release? HOT 2
- Various warnings compiling with visual studio HOT 1
- Insecure API when using in React Native iOS app HOT 1
- Set GitHub Workflow permissions to read only HOT 1
- [vulnerability] CVE issues HOT 4
- Hash Pin Github Owned Actions HOT 3
- Enable OpenSSF Scorecard Action and Badge HOT 1
- question: does abseil-cpp cover double-conversion functionality HOT 1
- fatal: unable to access 'https://github.com/google/double-conversion.git/': CONNECT tunnel failed, response 403 HOT 1
- Double google
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from double-conversion.