Fix -Wzero-as-null-pointer-constant warnings

[seanm]

Fix -Wzero-as-null-pointer-constant warnings

[seanm]

Ok, I'll attempt a patch.

[floitsch]

I added the -Wzero-as-null-pointer-constant flag to the build and didn't see any warnings.

Would it not be safe to just add the warning?

[seanm]

That's surprising because this repo does not contain the string nullptr: https://github.com/google/double-conversion/search?q=nullptr When I build, I do get such warnings from clang.

[seanm]

@floitsch maybe you need to explicitly specify a newer C++ version with say -std=c++17 for the warning flag to do anything.

But the question remains: What is the minimum C++ dialect this project supports?

[floitsch]

I must have done something wrong.
Tried again (this time with clang) and now I get warnings.

I never really thought about a minimum version, but I guess C++11 is fine.

Really a pity, that one can't just #define NULL nullptr...

[seanm]

many other projects do something like:

#if __cplusplus >= 201103L
#  define DC_NULLPTR nullptr
#else
#  define DC_NULLPTR NULL
#endif

[floitsch]

I think that's an acceptable solution.

In my new project we now use null:

constexpr std::nullptr_t null = nullptr;

I think something like that should work here too. (together with the #ifdef when it's not available).

[seanm]

Is there a .h file already included everywhere, where this can be put?

[floitsch]

I don't think there is one yet.
Maybe utils.h.
For simplicity I would put it there, since it's already included in most other sources.

[seanm]

Sorry, didn't anticipate needing a lawyer. :(

Hopefully someone else can fix the warnings.

Cheers.

[floitsch]

The project was created while I worked at Google. This bot is a requirement there. (Tbh, probably for good reasons).

That said: I can override the bot if the changes are small enough.
If you reopen the PR I can commit it.

[seanm]

The project was created while I worked at Google. This bot is a requirement there. (Tbh, probably for good reasons).

No doubt, but I've made this patch on my employer's time, which technically means involving them, which becomes complicated as you can imagine.

That said: I can override the bot if the changes are small enough.
If you reopen the PR I can commit it.

Done, thanks!