Giter Site home page Giter Site logo

Comments (6)

hagbard avatar hagbard commented on August 31, 2024 1

Apologies for not spotting some of these lingering issues (I'm not getting the email notifications I expected for this project). To put it in perspective a bit, Flogger deliberately doesn't take on the responsibility for configuring logging. That has to remain up to the underlying system for which the backend is configured.

Using the default JDK backend, you configure logging via all the normal JDK logging mechanisms. The same is true for Log4J (which now has a backend thanks to Edwin and the Gerrit team).

I hope that answers your question (and I'll look at updating the docs accordingly).

from flogger.

jbduncan avatar jbduncan commented on August 31, 2024 1

@hagbard Hmm, good question!

I think that adding a link to the main page of the Flogger website somewhere would be a good first step (e.g. at the end of the one-line description at the top of the GitHub page), just so that the main documentation is a bit more visible. See the Truth GitHub page for an example of what I mean.

image

I think then doing something like the following would be good: consider adding a sentence or two to the opening paragraph of the README and the main page explaining briefly that Flogger is a "frontend" logging framework which delegates logging to JUL and other frameworks, similarly to SLF4J. So the sentence:

Flogger is a fluent logging API for Java. It supports a wide variety of features, and has many benefits over existing logging APIs.

may become:

Flogger is a fluent logging API for Java. It supports a wide variety of features, and has many benefits over existing logging APIs. But it is not its own dedicated logging framework; similarly to SLF4J, it delegates to your logging framework of choice.

I think you'd then need to clarify somewhere what Flogger not being "its own dedicated logging framework" means. Maybe a separate page of information similar to the benefits and best practices pages?

I'm admittedly unclear on what the connection between this issue and LoggerConfig is. Would you mind clarifying for me?

from flogger.

fzakaria avatar fzakaria commented on August 31, 2024

Yes -- I'm accustomed to structured logging (log4j / slf4j); it wasn't clear that the normal backend is "JUL".
Seems like a SLF4J bridge would be very useful to play nicely with the rest of the logging uses in the wild

from flogger.

jbduncan avatar jbduncan commented on August 31, 2024

@ronshapiro I'm not sure if you're the right person to ask, but is there anything that's blocking this task at the moment, or has the Guava/Flogger team just not had the time to look at it yet?

from flogger.

hagbard avatar hagbard commented on August 31, 2024

@jbduncan where do you think adding new docs would make it clearest?

I've made a couple of changes in code docs for LoggerConfig (internally so far, but should be pushed in the next release). I regret making that class sound like it's a general configuration solution (it isn't).

from flogger.

madorb avatar madorb commented on August 31, 2024

Yes, what @jbduncan said, that's where i was confused when opening the initial ticket. It didn't seem to say anywhere whether it's just a frontend, or a frontend+backend - and calling it out right up front would be great IMO

from flogger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.