Represent optional JSON boolean as `*bool` in Go to avoid altering messages when deserializing and re-serializing

[google]

Represent optional JSON boolean as `*bool` in Go to avoid altering messages when deserializing and re-serializing

[corneliusweig]

It's very surprising that VSCode interprets undefined as truthy for showUser. This goes against common practice with optional fields in JS/TS or Go. In my opinion, the DAP spec states clearly that debug adapters can only expect that the message is shown when showUser: true:

/**
   * If true show user.
   */
  showUser?: boolean;

So I'm not convinced that this field should be changed to a pointer to make it optional, at least for this reason.

---

OTOH, you could argue that the DAP spec states that the field is optional (i.e. it is a tri-state), and this Go implementation does not support that. So this looks like a valid reason to me. However, pointer fields are much more error-prone and harder to work with. So if it is not strictly required to convert the field to pointer type, I'd prefer to keep it as-is.