Giter Site home page Giter Site logo

Comments (4)

Bobgy avatar Bobgy commented on July 17, 2024

We may need to split up to multiple regex patterns. For some, it doesn't make sense to remove the ^.

PR welcomed!

from go-licenses.

silverwind avatar silverwind commented on July 17, 2024

FWIW, Github does detect the license correctly on that repo. Maybe their code that does it is open-source, not sure.

Edit: It is https://github.com/licensee/licensee as per this. It uses a scoring system with multiple regexes.

from go-licenses.

Bobgy avatar Bobgy commented on July 17, 2024

Be careful with directly using other open source project's code, there are license issues.

It's good to know someone else also uses multiple patterns.

To add to that, the patterns can have different confidence level. If a file named LICENSE doesn't have a recognized license, we should raise an error. But if a file abcd-licenser.txt doesn't have license content, we can log a debug message instead.

Current behavior: we check for all files matching the regex, but we don't log an error at all for individual files.

from go-licenses.

silverwind avatar silverwind commented on July 17, 2024

Asked the author to rename in mrjones/oauth#74.

from go-licenses.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.