Giter Site home page Giter Site logo

Comments (8)

DylanMeeus avatar DylanMeeus commented on July 17, 2024

Running into the same issue here :/

from go-licenses.

gssbzn avatar gssbzn commented on July 17, 2024

@DylanMeeus the way we solved this was running go get with GO111MODULE=on, we just had to go thru some hoops on our ci as running go get with GO111MODULE=on in a folder with a go.mod file will add the dependency to the file (this is a known "feature" with no way around it so far) and we did not want that on our ci, hence why I think binaries would help a lot

from go-licenses.

DylanMeeus avatar DylanMeeus commented on July 17, 2024

Thanks @gssbzn, I'll give that a try!
Luckily nothing urgent though as we don't update our external dependencies all that often. Having release tags would help a great deal in preventing these issues :-)

from go-licenses.

RJPercival avatar RJPercival commented on July 17, 2024

Would a Docker image suffice? There's already a Dockerfile that should always build, and it should be relatively easy to release Docker images.

from go-licenses.

gssbzn avatar gssbzn commented on July 17, 2024

@RJPercival it would be a start for sure, our ci doesn't have the best docker support but we are working on it.
I also have some experience setting up goreleaser if that's an approach some of the contributors are willing to try I'm happy to make a PR but having something like that means the maintainers are happy to at least tag the release

from go-licenses.

RJPercival avatar RJPercival commented on July 17, 2024

They should be happy to tag a release; the v1 milestone is complete so I think it's ready for a v1.0.0 tag. I'm not so sure about goreleaser; they'll have to chime in there.

from go-licenses.

gssbzn avatar gssbzn commented on July 17, 2024

with go1.16 I think this can be closed as in theory now there's an option to not alter the the go.mod file, I still need to test this on our CI env as we are still adding 1.16 support

from go-licenses.

Bobgy avatar Bobgy commented on July 17, 2024

There are releases now and with go1.16+ go install github.com/google/go-licenses@latest, I think these problems are addressed. Please comment if it's still an issue.

from go-licenses.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.