Windows support

[google]

Windows support

[cushon]

https://ci.appveyor.com/project/eaftan/google-java-format/build/1.0.2

[sormuras]

Two tests in DiagnosticTest fail on Windows due to hard-coded line separators in combination with java.io.PrintWriter dynamic behaviour:

    /**
     * Line separator string.  This is the value of the line.separator
     * property at the moment that the stream was created.
     */
    private final String lineSeparator;

How do you want it to be fixed?

• remove \n from end of expected string and use contains instead of isEqualTo

assertThat(err.toString()).contains("<stdin>:2:4: error: Invalid character constant");

• replace \n with System.lineSeparator()

assertThat(err.toString()).isEqualTo("<stdin>:2:4: error: Invalid character constant" + System.lineSeparator());?

See #40

[jbduncan]

I recently suggested in junit-team/junit5#398 the use of AppVeyor to prevent these sorts of Windows-related errors from cropping up in the future.

What does the google-java-format team think about using AppVeyor here?

[sormuras]

AppVeyor would report: Tests run: 509, Failures: 270, Errors: 0, Skipped: 1 ... all CRLF related.

[jbduncan]

Haha, well then! Looks like a pretty convincing case for using AppVeyor to me.

[sormuras]

After converting all .[in|out]put files to \n line separators, the test reports: Tests run: 507, Failures: 15, Errors: 0, Skipped: 1

Maybe a .gitattributes could help:

*.input -text
*.output -text

The remaining 15 failures are extra \n characters where none are expected. Like in MainTest.importRemovalLines, there's an empty line rendered between the import and class block.

[sormuras]

#79 proposes a dynamic way for the line separator issue, which does not override the user choice of which line separator to use.

If the line separator used in output should be forced/user-defined, may be, another command line option can be introduced using an enum named OutputLineSeparator:

• AUTO_DETECT // use the separator used in input, implemented in #79
• DEFAULT // use the system-dependend default separator via System.lineSeparator()
• UNIX // force "\n"as line separator
• MAC // force "\r" as line separator
• WINDOWS / force "\r\n" as line separator

[sormuras]

Now, travis and local Windows machine agree: Tests run: 517, Failures: 0, Errors: 0, Skipped: 1

[sormuras]

If only Travis starts a build and there was a AppVeyor build ... this issue was solved. (-:

[jbduncan]

Ooh, great to see an AppVeyor build up and running! Thank you @eaftan and @cushon.

[eaftan]

Thank you guys for letting us know about AppVeyor. We've been looking for a Windows CI solution for several of our projects.

[jbduncan]

You're very welcome @eaftan. 👍

I look forward to seeing it being adopted across more Google OSS projects.