Bazel build broken

[google]

Bazel build broken

[jart]

Wonderful. Thank you @jan-wassenberg for all the work you put into unblocking an issue I'm trying to solve for @namrata-ibm.

[vks]

This is intended behavior introduced in 44f30a2. See #27 for more background. The workaround is to put the directory of the git clone into third_party/highwayhash subdirectories.

[jart]

I wrote 44f30a2 and it's not what I intended :)

[vks]

Huh, I did not know that, sorry. I thought it was intentional because of @jan-wassenberg's comments in #27:

FYI we had to change the include paths because -isystem is quite costly for Bazel. It would be nice if we can keep the source code the same internally and in Github.

It is admittedly unusual - do you have an idea how we could keep the source code identical between the internal/external repository and avoid sed scripts in both directions? I suppose we could ```#define''' the header names, but that's also ugly.

I don't really see how to fix this without resorting to some sed scripts or changing bazel.

[jart]

There are two solutions to choose from:

1. mkdir third_party && mv highwayhash third_party
2. Use MOE or Copybara, which are pretty standard, and replace the includes on export / import.

[jart]

Also getting rid of -isystem flags (the includes attribute in BUILD) is why I did it. But in order for it to work, the include paths in the repository need to be relative to the root of the repository.

[jan-wassenberg]

Thanks for your comments, looks like option 2 is less painful in the long term.
I'm leaning towards MOE (more powerful than sed) and will be able to do this in a few days.

[jart]

Feel free to mail me the CL making the MOe configuration change. I'll be happy to review.

[jan-wassenberg]

Thanks, will do!

[jan-wassenberg]

Thank you for reviewing. MOE worked, the resulting huge commit is pushed.
This removes the third_party/highwayhash prefix, which I trust fixes the issue. If not, please feel free to reopen!

[jart]

Where did the BUILD file go?

[jan-wassenberg]

Wasn't included in highwayhash_opensource_filegroup. I like your idea of a SipHash-specific BUILD file, but please let me know if you want the entire BUILD file back.