Unmarshalling Payload for jsonAPI PATCH

[google]

Unmarshalling Payload for jsonAPI PATCH

[aren55555]

@iderdik I'd suggest using pointers for fields that permit nil values.

type Car struct {
  ...
  PurchasedAt *time.Time `jsonapi:"attr,purchased_at"`
  ...
}

[iderdik]

Thanks, that should work.

[iderdik]

After changing the struct members to pointers, I now get:

data is not a jsonapi representation of '*models.xxxx'"

I haven't changed anything else about the struct. Are pointers handle differently?

[aren55555]

@iderdik can you post an example of the struct you are trying to serialize/deserialize?

[iderdik]

@aren55555 Further research shows that this error happens when there are *string members in the struct. This is the line that panics: https://github.com/shwoodard/jsonapi/blob/master/request.go#L312

It looks like there might be a need for a check if reflect.Kind() is a pointer and handle appropriately.

This code in that spot made it work for me:

if fieldValue.Kind() == reflect.Ptr {
  strval := val.(string)
  fieldValue.Set(reflect.ValueOf(&strval))
} else {
  fieldValue.Set(reflect.ValueOf(val))
}

Of course it assumes that the value is *string so you still might need a default case handler.

[iderdik]

And this all seems to be dealt with in this PR :) https://github.com/shwoodard/jsonapi/pull/28 Any chance that will get merged soon?

[aren55555]

@iderdik master now has the commits that support fields of *string