Proposal: Disposer

[google]

Proposal: Disposer

[alexeieleusis]

There is a public implementation now at https://github.com/dart-lang/angular_components/blob/master/lib/src/utils/disposer/disposer.dart
Could it be imported/copied here? It seems to be stable enough that is unlikely for it to change, once is here it can be used from flutter/angular/butterfly/etc.
And once here it can be integrated with static analysis tools like requested here dart-lang/linter#285

[matanlurey]

This probably doesn't belong in quiver.

Angular at least would prefer not to require a dependency on it for the runtime; I'd prefer something like pkg/dispose, but I'll wait to see what someone like @kevmoo thinks.

[cbracken]

I'd definitely prefer not to add entirely new areas of functionality to quiver.

[yjbanov]

Whatever use-cases there were back in 2014 that prompted me to file this feature request are no longer relevant to me personally. Unless someone else champions this feature, I'm ok with closing.

[alexeieleusis]

@matanlurey where is this pkg/dispose you mention? Or your suggestion is to create a new one?

The reason I am interested in this is because it is a common pattern in my team to add stream controllers and subscriptions to the mentioned disposer and that disables warnings to close or cancel them respectively, but the disposer could be not disposed and memory leaks potentially can be there.

[matanlurey]

We do not have this package, I'll chat with the Dart team about creating one - otherwise Angular will be very reluctant on taking on this dependency.

That being said, this doesn't seem appropriate for a linter, as it's package specific. Any team could create a MyStreamCleaner and not get lint warnings. I'd prefer to wait for the proposed new analyzer plugins - then pkg/dipose (or w/e is created) could publish its own analysis plugin.

[matanlurey]

@yjbanov Feel free to close this issue, we can continue discussions elsewhere if needed.