Comments (7)
Is it still true that services have to be Clone
when using FutureService
? As far as I can tell, the tokio event-loop will only handle one event internally at a time, and so the service won't need to be cloned?
from tarpc.
To be honest, I don't know why anymore! the tokio_service::Service
trait used to have a Send
bound, which meant services needed to either be Sync
(and wrapped in an Arc
) or Clone
, and the latter is a generalization of the former. However, I believe the Send
bound was removed from Service
so this all needs to be revisited. This is one of the things I want to sort out before the next release, and I really want to ship it this week, so stay tuned (or feel free to investigate it independently; PRs always welcome).
from tarpc.
Currently, this is still true. Some of this code needs to be cleaned up -- for instance, there's a Send
bound on FutureService
that only exists on the off chance the user wants to start the service via a reactor::core::Remote
(a Handle
wouldn't require Send
). So the bottom line is there is work to do here, but I think if you just wrap your service in an Rc
for now it should be fine.
from tarpc.
Hmm, why is that (that Clone
is necessary that is)? Is it fundamental? If not, is there a chance that FutureService
methods might start taking a &mut self
in the future?
from tarpc.
We briefly discussed this a while ago but I can't find the discussion right now. I believe from that discussion that it wasn't particularly tied to FutureService
though?
from tarpc.
(btw, let's move this conversation to #86)
from tarpc.
Just leaving a note that we also ought to include a generated service somewhere so that the docs contain an easy-to-reference list of things like methods of FutureService
.
from tarpc.
Related Issues (20)
- Bidirectional RPC HOT 3
- Cross Platform Procedure Call HOT 2
- [FEATURE REQUEST] Stream responses HOT 4
- QUESTION: how to get tcp server features for custom transport? HOT 1
- Consider making tracing optional HOT 8
- Bubble up server side transport errors to the client HOT 5
- Design problem, how to call other structs method ?
- Server-side span with client’s span as parent HOT 3
- Recommended way for connection pooling? HOT 4
- Support for Async Fn in Trait? HOT 3
- Generic type parameters HOT 4
- On client's read errors quick subsequent requests may wait for response indefinitely HOT 9
- Adding client ID to identify clients (and retrieve specific context)? HOT 2
- Associated data with client
- Future returned by `Serve::serve()` is not `Send` HOT 11
- Add a way to derive Clone for the generated Request and Response types HOT 5
- Rkyv support?
- Json support and automatic documentation generation HOT 2
- Feature: cli support for translating defined placeholder to generate proto from codebase directly
- tarpc make crash when c++ Destructor execute
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tarpc.