Giter Site home page Giter Site logo

Comments (8)

Gabswim avatar Gabswim commented on July 22, 2024 1

I have a workaround: installing the yaml library directly if the goal is to restrain the API to a smaller footprint.

But the parseAllDocuments code is still in the bundle?

Yes, so right now the typing is not showing the reality of what is being accessible.
Maybe what you can do is something like this

import { parse, stringify } from 'yaml'

export const YAML = {
  parse,
  stringify
}

from zx.

antongolub avatar antongolub commented on July 22, 2024

This is related to TS case, right?

  1. The issue can be fixed, but it will also add ~50Kb to dts libdefs.
  2. If we'd like to replace the current YAML engine with another one (smaller, faster, etc), no chance that it will also provide support for parseDocument/parseAllDocuments

CC @antonmedv

from zx.

antonmedv avatar antonmedv commented on July 22, 2024

This is because we bundle yaml?

from zx.

antongolub avatar antongolub commented on July 22, 2024

Because we've omitted the API typings except parse and stringify.

from zx.

antonmedv avatar antonmedv commented on July 22, 2024

But the parseAllDocuments code is still in the bundle?

from zx.

antongolub avatar antongolub commented on July 22, 2024

But the parseAllDocuments code is still in the bundle?

Correct. In js bundle.

from zx.

antonmedv avatar antonmedv commented on July 22, 2024

But why ts def grows so much?

from zx.

antongolub avatar antongolub commented on July 22, 2024

External contracts are derived from internal ones. There are actually many many types.
https://www.npmjs.com/package/yaml?activeTab=code

from zx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.