Giter Site home page Giter Site logo

Comments (8)

jmuk avatar jmuk commented on July 24, 2024

@landrito, this is the one we chatted.

from artman.

landrito avatar landrito commented on July 24, 2024

Gotcha, I'll look into it!

from artman.

garrettjonesgoogle avatar garrettjonesgoogle commented on July 24, 2024

I did want to note that the "similar to Java" comment is not correct - Java was converted to use packman (opposite conversion as proposed here for Ruby).

At a higher level, I'm not a huge fan of this mix of doing some generation in packman and some in artman. It seems preferable to make only one component responsible.

from artman.

jmuk avatar jmuk commented on July 24, 2024

Hmmm, I didn't know that, thank you for the info.

Then, I am quite unsure what needs to be done here... possibly:

  • fix packman templates -- remove README or gemspec files. Then purely run protoc.
  • modify artman task to copy the packman results to the final_repo_dir
    ?

from artman.

garrettjonesgoogle avatar garrettjonesgoogle commented on July 24, 2024

I think it could make sense for artman to copy the packman results to final_repo_dir.

from artman.

landrito avatar landrito commented on July 24, 2024

For clarifications sake, we are copying rather than generating directly to the final_repo_dir to avoid the case where generation fails partway through only generating some of the files?

from artman.

garrettjonesgoogle avatar garrettjonesgoogle commented on July 24, 2024

Yes, we always generate directly into a temp dir under output/.

from artman.

jmuk avatar jmuk commented on July 24, 2024

Let me reopen this, I think the original description still makes sense.

The justification is that we actually don't need package definition files for gRPC clients, because we don't create an independent package for gRPC client. Instead Gapic client package should contain .rb files for both Gapic and gRPC clients. Now it's better for artman to invoke proto-compiler rather.

from artman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.