Comments (8)
@landrito, this is the one we chatted.
from artman.
Gotcha, I'll look into it!
from artman.
I did want to note that the "similar to Java" comment is not correct - Java was converted to use packman (opposite conversion as proposed here for Ruby).
At a higher level, I'm not a huge fan of this mix of doing some generation in packman and some in artman. It seems preferable to make only one component responsible.
from artman.
Hmmm, I didn't know that, thank you for the info.
Then, I am quite unsure what needs to be done here... possibly:
- fix packman templates -- remove README or gemspec files. Then purely run protoc.
- modify artman task to copy the packman results to the final_repo_dir
?
from artman.
I think it could make sense for artman to copy the packman results to final_repo_dir.
from artman.
For clarifications sake, we are copying rather than generating directly to the final_repo_dir to avoid the case where generation fails partway through only generating some of the files?
from artman.
Yes, we always generate directly into a temp dir under output/.
from artman.
Let me reopen this, I think the original description still makes sense.
The justification is that we actually don't need package definition files for gRPC clients, because we don't create an independent package for gRPC client. Instead Gapic client package should contain .rb files for both Gapic and gRPC clients. Now it's better for artman to invoke proto-compiler rather.
from artman.
Related Issues (20)
- Missing input file. should be more descriptive HOT 7
- Go: run goimports as part of artman script HOT 15
- Go: release level not being considered HOT 3
- Switch to composer from pear for PHP dependencies HOT 5
- Python: include enums in generated documentation HOT 5
- Error while finding module specification for 'grpc_tools.protoc' (ModuleNotFoundError: No module named 'grpc_tools') HOT 6
- Typos in CONTRIBUTING.rst
- Nested package proto imports fail for Python HOT 2
- --local runs are broken HOT 3
- Samples are not being generated (as of 0.29.1) HOT 3
- Add sample generation to golden test (to catch samplegen regressions) HOT 2
- artman: pull the artman image for me HOT 4
- module has no attribute FullLoader HOT 1
- mysterious error HOT 1
- un-whitelist monitoring
- Java: update protoc plugin
- fix cel API generation HOT 4
- allow passing extra command line options to protoc HOT 1
- Does not work on the github.com/google/fhir protobufs?
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artman.