Missing dependency request causes an error when using Google Cloud's Vision API

[tferrerm]

Missing dependency request causes an error when using Google Cloud's Vision API

[leahecole]

Hi @jahabeebs thank you for the update, good to know! Yes, the next release when we cut it should include #1612, and our automation should push that out to client libraries soon - I'll poke some folks for reviews today to make sure everything is okay with cutting that release hopefully today. Request shouldn't have to be a dependency once that happens especially given that that outdated line of code is removed from the version of retry-request found in gax already.

[jahabeebs]

Also facing this issue when using ^6.4.0 of @google-cloud/language w/Next.js

[teamclouday]

@google-cloud/compute with nextjs is having the same issue

[Anisotropic]

Faced the same issue while using firebase with nodeJs

[leahecole]

Apologies for the closure, reopen, re closure. Some more info:

Part of retry-request functionality has been migrated into gax with the goal of not needing to depend on retry-request at all in a future major version. Until #1612, we also had that extremely outdated require('request') in there, which had come from retry-request. That has since been cleaned up both in gax and in retry-request. Gax now depends on retry-request versions that no longer have this problem.

I just verified, and vision depends on a version of gax where this has since been fixed, as do the latest versions of google-cloud-language

[jahabeebs]

google-cloud-language

Hi @leahecole, I'm using the latest version of @google-cloud/language (6.4.0) and this issue is still present. Are you saying in future releases it'll include your #1612 fix and we won't have to keep request as a dependency anymore?