Giter Site home page Giter Site logo

Comments (4)

bcoe avatar bcoe commented on July 28, 2024 1

@JustinBeckwith a warning might be enough, but I think a cleaning step that lowercases headers would be good, that way upstream libraries that build on top of gaxios, e.g., google-auth-library need not check every combination of a given header.

from gaxios.

kungfutse avatar kungfutse commented on July 28, 2024

Headers are case-insensitive according to RFC2616 so this is a bug, not a feature request, in my opinion.

from gaxios.

JustinBeckwith avatar JustinBeckwith commented on July 28, 2024

I'm not sure what the actual bug is here :) Can someone give me an example? Right now the request.Headers field is just a POJO.

For example:

const options: GaxiosOptions = { 
  headers: {
    'content-type': 'application/json',
    'Content-Type': 'text/xml',
  },
},

We could look for this situation and throw if we find duplicate keys once lower cased?

from gaxios.

danielbankhead avatar danielbankhead commented on July 28, 2024

We should adopt the native Headers class to resolve this; we'll look into this in the next major 😉

from gaxios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.