Comments (2)
How do you think this should be exposed in the ruby client? There are only three possible values defined in the protobuf definition, and I would like to avoid client code that looks like the following:
query = Gcloud::Datastore::Query.new.kind("Task").
where("completed", "=", true)
tasks = dataset.run query
if tasks.more_results == "NOT_FINISHED"
# do something here
end
I think it would be best to rely on named convenience methods instead. So something more like this:
query = Gcloud::Datastore::Query.new.kind("Task").
where("completed", "=", true)
tasks = dataset.run query
if tasks.not_finished?
# do something here
end
So my question is what should these convenience methods should be named? Here is what I'm thinking:
NOT_FINISHED
->results.not_finished?
MORE_RESULTS_AFTER_LIMIT
->results.more_after_limit?
NO_MORE_RESULTS
->results.no_more?
I would much rather assert a positive than a negative, so results.not_finished?
and results.no_more?
bother me, but I don't know if this is something that can be changed due to the way the protobuf API was designed.
from google-cloud-ruby.
Closed by #42.
from google-cloud-ruby.
Related Issues (20)
- [Nightly CI Failures] Failures detected for google-cloud-build-v1 HOT 2
- Compute: `disks` is a required param even when creating an instance from an instance template HOT 2
- [Nightly CI Failures] Failures detected for google-cloud-vision-v1p3beta1 HOT 5
- [Nightly CI Failures] Failures detected for google-cloud-vision-v1 HOT 5
- [Nightly CI Failures] Failures detected for google-cloud-container_analysis-v1 HOT 5
- [Nightly CI Failures] Failures detected for google-cloud-vision-v1p4beta1 HOT 5
- Provide an example of using the WebRisk API in Ruby HOT 6
- Warning: a recent release failed
- Warning: a recent release failed
- Warning: a recent release failed
- Warning: a recent release failed
- Warning: a recent release failed HOT 1
- Warning: a recent release failed HOT 1
- storage: Add Support for manual managed folders feature includeFolders
- storage: implement soft delete
- Assigning MIG instance template (PATCH) fails with `named ports are immutable` error
- [Nightly CI Failures] Failures detected for google-cloud-storage HOT 1
- [Nightly CI Failures] Failures detected for google-cloud-errors HOT 7
- [Nightly CI Failures] Failures detected for google-cloud-core HOT 7
- NoMethodError: undefined method `is_a?' for <Config HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-cloud-ruby.