Giter Site home page Giter Site logo

Comments (5)

kjhughes avatar kjhughes commented on August 17, 2024

Seeking clarification on the code update part of the issue: While this commit migrated angularfire-seed to the new authentication methods, it did so by modifying app/js/simpleLogin.js without changing its name. The issue here is to eliminate use of the name 'simpleLogin' because it connotes association with the deprecated Firebase Simple Login library?

from angularfire-seed.

jwngr avatar jwngr commented on August 17, 2024

Yes, you are exactly right. This is using the newest auth methods, but the naming is the confusing thing for people, myself included. Ideally we would not use the phrase "Simple Login" at all in this repo, including in filenames, variable names, and comments.

from angularfire-seed.

djindjic avatar djindjic commented on August 17, 2024

oh yes, I agree with that. I'm not very deep in angularfire but I currently have a problem with login and wanted to ask is it old simple login or just name convection. So, this is new auth method and just file named simpleLogin.js?

from angularfire-seed.

jwngr avatar jwngr commented on August 17, 2024

Yes, it is the new methods with the old name. We will fix this.

from angularfire-seed.

katowulf avatar katowulf commented on August 17, 2024

Remove anything prefixed with "simple" in 1.0.0 to avoid confusion.

from angularfire-seed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.