Giter Site home page Giter Site logo

Comments (9)

patrickhulce avatar patrickhulce commented on June 22, 2024 2

This flag is still in use in the Chromium codebase AFAICT, so we would like to continue supporting it, but we've added ignoreDefaultFlags as a way to disable other default flags in chrome-launcher that doesn't yet affect this one.

If anyone would like to submit a PR that adds a check for ignoreDefaultFlags to

if (getPlatform() === 'linux') {
flags.push('--disable-setuid-sandbox');
}

I think that sounds good! 👍

from chrome-launcher.

paulirish avatar paulirish commented on June 22, 2024

AFAIk this flag IS used: https://cs.chromium.org/search/?q=kDisableSetuidSandbox&sq=package:chromium&type=cs

See the zygote_host_impl_linux.cc results.

from chrome-launcher.

paulequilibrio avatar paulequilibrio commented on June 22, 2024

Hi guys,
I need to launch a headless chrome without this flag to run my tests.
There is any particular reason to this flag be obligatory on Linux?

from chrome-launcher.

zaaack avatar zaaack commented on June 22, 2024

This flag would cause this error and cannot launch chrome

27907:27907:0205/194525.657250:FATAL:zygote_host_impl_linux.cc(107)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux_suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.
[1]    27907 abort      /usr/bin/google-chrome-stable --disable-translate --disable-extensions 

from chrome-launcher.

calebeby avatar calebeby commented on June 22, 2024

Any reason why @samccone's commit wasn't merged? I'd love to get rid of this annoying warning 🤔

from chrome-launcher.

patrickhulce avatar patrickhulce commented on June 22, 2024

@calebeby see #68 (comment), if you'd like to be the one to pick it up, be our guest :)

from chrome-launcher.

calebeby avatar calebeby commented on June 22, 2024

@patrickhulce I'm not sure I completely understand the relation between this issue and the linked PR. If I submitted a PR that just removed the --disable-setuid-sandbox flag, but didn't do anything else related to Alpine linux, would that be accepted?

from chrome-launcher.

marklochrie50265 avatar marklochrie50265 commented on June 22, 2024

any update on this?

from chrome-launcher.

JavaScriptDude avatar JavaScriptDude commented on June 22, 2024

I have found a workaround for this on Linux.

You can use the ignoreDefaultFlags setting as follows:

const ChromeLauncher = require('chrome-launcher');

var flags = ChromeLauncher.Launcher.defaultFlags();

// optional: filter out flags
// Eg. Enabling extensions and Audio
// flags = flags.filter(flag => flag !== '--disable-extensions' && flag !== '--mute-audio')

// optional: Add you own flags
// flags.push('--proxy-server=192.168.101.200:8213')

ChromeLauncher.launch({
   startingUrl: ''
  ,userDataDir: '/dpool/vcmain/sys/chrome/profiles/CORP_DEV_LOCAL'
  ,ignoreDefaultFlags: true
  ,chromeFlags: flags
}).then(chrome => {
  console.log(`Chrome debugging port running on ${chrome.port}`);
});

from chrome-launcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.