Comments (4)
More than happy to land a PR adding it as the default export and or making documentation change to make this explicit
Thanks again!
from chrome-launcher.
Hello and thanks for reaching out.
looking here at the code, we have no default export
https://github.com/GoogleChrome/chrome-launcher/blob/master/chrome-launcher.ts#L85
thus this is working as implemented.
Did you see a code example that made you think you could import using the default syntax? If so we should fix that.
Thanks so much for taking time out of your day to open a bug!
from chrome-launcher.
The documentation uses the require pattern, so there there is nothing wrong with it, but people using ES6 imports (my case) have to guess (or just check the source code 😄 ) which pattern to use. Since default import is more common it was the behaviour I was expecting.
from chrome-launcher.
shipped in 0.10.0
from chrome-launcher.
Related Issues (20)
- Reporting unsuccessful exit code
- crash when launch with remote debugging pipe
- Reuse an existing window HOT 1
- RangeError [ERR_FS_FILE_TOO_LARGE]: File size (3055630622) is greater than 2 GiB
- Chrome launcher wont launch HOT 1
- Beta and Dev channels are not detected
- igmore
- /Users/sample/node_modules/chrome-launcher/dist/chrome-finder.js:14 const log = require('lighthouse-logger'); ^ Error [ERR_REQUIRE_ESM]: require() of ES Module HOT 1
- Unknown error when ChromeLauncher.launch() in worker thread HOT 1
- Version v0.15.2 and kill chrome instance HOT 3
- Update readme for 1.0.0: ERR_REQUIRE_ESM
- `prefs` option doesn't work HOT 3
- Issue determining temp dir path HOT 1
- flag for setting useragentdata
- How to access environments variable with JS in chrome?
- move the red error dot to the console tab where it belongs HOT 1
- Add `--enable/disable-features=ChromeRootStoreUsed` flag HOT 2
- `user-data-dir` improperly replaced with Win32 path when running in WSL
- prefs option is incorrectly treated as a flat Record<string,JSONLike>, nested objects are not merged but overwritten HOT 1
- Search-engine dialog HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chrome-launcher.