Giter Site home page Giter Site logo

Comments (4)

samccone avatar samccone commented on September 23, 2024 1

More than happy to land a PR adding it as the default export and or making documentation change to make this explicit

Thanks again!

from chrome-launcher.

samccone avatar samccone commented on September 23, 2024

Hello and thanks for reaching out.

looking here at the code, we have no default export
https://github.com/GoogleChrome/chrome-launcher/blob/master/chrome-launcher.ts#L85
thus this is working as implemented.

Did you see a code example that made you think you could import using the default syntax? If so we should fix that.

Thanks so much for taking time out of your day to open a bug!

from chrome-launcher.

mokahaiku avatar mokahaiku commented on September 23, 2024

The documentation uses the require pattern, so there there is nothing wrong with it, but people using ES6 imports (my case) have to guess (or just check the source code 😄 ) which pattern to use. Since default import is more common it was the behaviour I was expecting.

from chrome-launcher.

paulirish avatar paulirish commented on September 23, 2024

shipped in 0.10.0

from chrome-launcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.