Comments (8)
Once https://codereview.chromium.org/1835063002/ lands, enable-add-to-shelf will not be required.
Star https://bugs.chromium.org/p/chromium/issues/detail?id=540491 for updates.
In the meantime, we can force the flag for node, but not for extension.
We might want to consider requiring Canary for using the extension. (Otherwise we'll be waiting for fixes like this to hit stable)
from lighthouse.
This will also mean we can clean up the depedency on request
and the localized requires here
from lighthouse.
Okay another bug we'll get resolved... on https://operasoftware.github.io/pwa-list/ things fail because it's in a subfolder and our browser fetching assumes manifest is at domain root.
There's a fix for it but I think I'd rather rely on the real thing.
from lighthouse.
@brendankenny when do you think you'll have a PR up for this?
from lighthouse.
Aiming for tomorrow
from lighthouse.
@brendankenny sounds good thank ya
from lighthouse.
so, one additional development here seems to be that in Canary, if you have Add to shelf
enabled in about:flags, Chrome now fetches the manifest on navigation. Is this coming sooner than we expected?
from lighthouse.
try https://jakearchibald.github.io/svgomg/ with your PR. i get invalid JSON errors with the extension currently.
from lighthouse.
Related Issues (20)
- How to configure triggered of the end of a navigation?
- Utilize localized failure messages from axe HOT 1
- Excessive style recalcs caused by CSS usage tracking HOT 4
- Improve documentation on standalone mode runners HOT 5
- Page crashes when running test from large DOM.getDocument response HOT 4
- Unexpected changes in main thread time reported around March 8th HOT 10
- Sequential network requests are simulated as parallel and the first rtt is ignored
- Lone surrogate character breaks PSI proto conversion HOT 4
- Was filing bug report when site crashed multiple before I could get the first report in HOT 2
- On certain audited pages, `totalBodyElements` are different from `MainDocumentContent` body nodes count HOT 1
- The Future of WordPress in the Age of AI Integration HOT 2
- Site security issues while making payment to Comcast. HOT 1
- SEO updates from recent search conversations
- Unexpected changes on main thread work from 11.6.0 to 11.7.1 HOT 3
- Viewport resizing to window size
- Lighthouse LCP Issue HOT 1
- LCP not recognized in many pages for this site. HOT 1
- Print stylesheet picked for Render-blocking resource HOT 1
- Incorrect user agent on pagespeed.web.dev HOT 1
- Protocol error (Target.getTargetInfo): Protocol error (Target.getTargetInfo): 'Target.getTargetInfo' wasn't found HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lighthouse.