Comments (5)
Thanks for your contribution, but this feature is already in the code:
https://github.com/GoogleChrome/omnitone#foadecoder
https://github.com/GoogleChrome/omnitone#foarouter
FYI, this is much faster than splicing array.
from omnitone.
Are you saying it is ordering internally already for Safari sorry ? Or externally it is required to manually reorder for Safari depending what the custom channel order is ?
It's confusing what is required in regards to that config that is all.
I've implemented it here so the user doesn't have to do anything at all to treat it differently for Safari. I've tested Safari now and it seems to be working with the cors proxy of course and an mp4.
The demo video from the site seems to work across browsers but I hear phasing because the source is very noisy. So the noise floor is doubling which increases it's gain, then when rotating I can hear the phasing. It'a possibly self noise from a bad mic or preamp noise from low grade equipment.
https://github.com/danrossi/three-vr-omnitone/blob/master/src/OmniToneAudio.js#L109
from omnitone.
@danrossi You can do whatever you want in your package and I appreciate your effort on that. It is really nice to have a package that connects Omnitone and Three.js. However, I want to keep the channel rerouting option flexible within Omnitone. I don't want to make things special only for Safari.
Regarding the sound quality, I suggest you to file another entry for that. It is not relevant to this issue.
from omnitone.
That is what I'm trying to figure out and glean information from.
The documentation is a little confusing.
I'm remapping whatever is sent to it according to the order Safari needs. If that is wrong then it would be good to know although it seems to work. I don't believe there should be the need for two different configs if it can be done dynamically I think.
The method was just a static helper method to be added to your library to be used externally on the channelMap config. Not remapped internally. That's perfectly fine mate !
from omnitone.
I'm remapping whatever is sent to it according to the order Safari needs. If that is wrong then it would be good to know although it seems to work. I don't believe there should be the need for two different configs if it can be done dynamically I think.
Yes, that is my point. If you want to add that static method into your wrapper-like utility, that is fine by me. Omnitone already supports the dynamic channel remapping and your wrapper is using it to remap the channels for Safari. I think this is quite natural to me.
from omnitone.
Related Issues (20)
- Airplane example does not work HOT 2
- Renderer setters don't work until after initialize promise resolves HOT 1
- Hoa-renderer
- HOARenderer HOT 1
- Using NPM-installed version with bundler HOT 1
- Content Security Policy and an 'unsafe-eval' Error
- Display audio download progress
- Omnitone and react-three-fiber?
- Current Status of the Project HOT 2
- Use with Babylon JS to play prebaked ambisonic audio
- Make landing page demos mobile-friendly
- Thrown errors not catchable HOT 6
- Reducing library size (optimization, packaging) HOT 13
- Apply ambisonics to an audio file then to a video file result to a non playable video HOT 12
- Better support for Three.js integration HOT 7
- Sound crackling with a html video element HOT 7
- Omnitone integration ES6 HOT 2
- Error installing fsevents dependency HOT 3
- Documentation on supported media formats for HOA HOT 14
- Update ex-opus-multichannel hoa-player with drag and drop to Main branche HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from omnitone.