Giter Site home page Giter Site logo

Comments (15)

thiagowfx avatar thiagowfx commented on June 28, 2024

Cannot reproduce (M1 Pro):

image

from chrome-for-testing.

dtoms avatar dtoms commented on June 28, 2024

Interesting, thank you. that does work when launched from the command line. It did not work for me when launched from finder. That's not really the important use case but was confusing. Is that expected?
Screenshot 2023-07-23 at 8 37 51 AM

from chrome-for-testing.

thiagowfx avatar thiagowfx commented on June 28, 2024

Also cannot reproduce, see screenshot below (you can see I don't get the overlay 🚫 icon).

I'm glad it works for you from the command-line so that it doesn't block you. Not sure why the behavior in Finder is different for both of us though.

image

from chrome-for-testing.

dtoms avatar dtoms commented on June 28, 2024

That screenshot was helpful. Here was some additional blurbs when I launched via the command line.

My arch is arm64, but the install process installed mac-115.0.5790.102/chrome-mac-x64/ whereas your screenshot shows chrome-mac-arm64...

daniel.toms@Q9JQNC9X77 ~ % arch                                         
arm64
daniel.toms@Q9JQNC9X77 ~ % npx @puppeteer/browsers install chrome@stable
[email protected] /Users/daniel.toms/chrome/mac-115.0.5790.102/chrome-mac-x64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing
daniel.toms@Q9JQNC9X77 ~ % cd  /Users/daniel.toms/chrome                
daniel.toms@Q9JQNC9X77 chrome % mac-115.0.5790.102/chrome-mac-x64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing
zsh: no such file or directory: mac-115.0.5790.102/chrome-mac-x64/Google
daniel.toms@Q9JQNC9X77 chrome % mac-115.0.5790.102/chrome-mac-x64/Google Chrome for Testing.app/Contents/MacOS/G                       
daniel.toms@Q9JQNC9X77 chrome % "mac-115.0.5790.102/chrome-mac-x64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing"
[57465:259:0723/083617.892174:ERROR:chrome_browser_main.cc(1036)] The use of Rosetta to run the x64 version of Chromium on Arm is neither tested nor maintained, and unexpected behavior will likely result. Please check that all tools that spawn Chromium are Arm-native.
[57465:259:0723/083621.062646:ERROR:chrome_browser_cloud_management_controller.cc(162)] Cloud management controller initialization aborted as CBCM is not enabled.

from chrome-for-testing.

dtoms avatar dtoms commented on June 28, 2024

So it seems like my mac has rosetta running and the installer chooses to install a different architecture. i don't know if that's something that can/should be fixed, or perhaps, noted somewhere. or if its just my own environment problem to deal with. i would suspect others would hit this in the future though.

from chrome-for-testing.

mathiasbynens avatar mathiasbynens commented on June 28, 2024

FYI @OrKoN. Is @puppeteer/browsers selecting the wrong architecture?

from chrome-for-testing.

OrKoN avatar OrKoN commented on June 28, 2024

I am not able to reproduce:

❯ arch
arm64
❯ npx @puppeteer/browsers install chrome@stable
Downloading chrome r115.0.5790.102 - 121.5 MB [====================] 100% 0.0s
[email protected] /Users/alexrudenko/src/pptr-test/chrome/mac_arm-115.0.5790.102/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing

from chrome-for-testing.

OrKoN avatar OrKoN commented on June 28, 2024

We rely on Node to detect the platform. What does node -e "console.log(require('os').arch())" return for you? It should be the same as arch.

from chrome-for-testing.

dtoms avatar dtoms commented on June 28, 2024

Ah, got it. We use asdf and are on an old node version 16.13.1 which does not correctly detect the arch. Switching to v20.5.0 and its correctly detected and Chrome for Testing works as expected. You might consider adding a nodejs check to the install, or a note to the FAQ, or perhaps this issue will help future travelers. Thanks all!

(not sure the closing protocol here so will leave open)

from chrome-for-testing.

thiagowfx avatar thiagowfx commented on June 28, 2024

@OrKoN Do you want to move the issue to https://github.com/puppeteer/puppeteer before we close this bug, or is would you say it is WAI?

from chrome-for-testing.

OrKoN avatar OrKoN commented on June 28, 2024

not sure, I am unable to reproduce this behaviour:

❯ nvm exec 16.13.1 node -e 'console.log(require("os").arch())'
Running node v16.13.1 (npm v8.1.2)
arm64

I think it is WAI and we can close this bug given that node 16 is reaching EOL in September.

from chrome-for-testing.

dtoms avatar dtoms commented on June 28, 2024

for posterity, with asdf

daniel.toms@Q9JQNC9X77 ~ % asdf local nodejs 16.13.1
daniel.toms@Q9JQNC9X77 ~ % node -e 'console.log(require("os").arch())'                         
x64

from chrome-for-testing.

OrKoN avatar OrKoN commented on June 28, 2024

@dtoms so this is an bug specifically with asdf? do you know if there is an open bug report?

from chrome-for-testing.

dtoms avatar dtoms commented on June 28, 2024

@OrKoN I don't know sorry.

from chrome-for-testing.

thiagowfx avatar thiagowfx commented on June 28, 2024

Since it's working with nvm, we can just close this. If more issues come up related to asdf then we can reconsider.

from chrome-for-testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.